build: darwin/arm builders broken by content-based build CL #22509
Comments
|
Thanks for putting up with the difficult mobile os'es. Off the top of my head:
Not sure if any is relevant. |
|
I can reproduce locally without an ios device. One unrelated point: iostest.bash runs The root cause appears to be that when you do a cross-compile build it looks like the CC_FOR_TARGET gets recorded as the default $CC for both host and target builds, so the host binaries look out of date during the run.bash half (because they were not built with CC=$CC_FOR_TARGET). Related to #8161 in part. Update: iostest.bash says |
|
Off to a meeting but will keep at this later. |
|
Change https://golang.org/cl/76018 mentions this issue: |
|
Change https://golang.org/cl/76020 mentions this issue: |
Even though cmd/dist has historically distinguished "CC for gohostos/gohostarch"
from "CC for target goos/goarch", it has not recorded that distinction
for later use by cmd/cgo and cmd/go. Now that content-based staleness
includes the CC setting in the decision about when to rebuild packages,
the go command needs to know the details of which CC to use when.
Otherwise lots of things look out of date and (worse) may be rebuilt with
the wrong CC.
A related issue is that users may want to be able to build a toolchain
capable of cross-compiling for two different non-host targets, and
to date we've required that CC_FOR_TARGET apply to both.
This CL introduces CC_FOR_${GOOS}_${GOARCH}, so that you can
(for example) set CC_FOR_linux_arm and CC_FOR_linux_arm64
separately on a linux/ppc64 host and be able to cross-compile to
either arm or arm64 with the right toolchain.
Fixes #8161.
Half of a fix for #22509.
Change-Id: I7a43769f39d859f659d31bc96980918ba102fb83
Reviewed-on: https://go-review.googlesource.com/76018
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
|
Supposed to be fixed now. We will see. |
|
@eliasnaur I did fix the failure we were seeing. Now we are seeing different failures. I am not sure what to make of them. Can you take a look and maybe file a new issue if you can see more? |
|
Thanks. It looks unrelated to the content-based caching. #22612 |
Looks like I broke the darwin/arm builders with my CL 73212. Investigating.
The log at https://build.golang.org/log/83cd0cb12afd4ff5069c6a9a72b124e02d21127c makes it look like there are two different make.bash runs, which maybe is part of the problem.
/cc @eliasnaur @crawshaw
The text was updated successfully, but these errors were encountered: