Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/importer: fix and enable TestFor for gccgo #22500

Open
rsc opened this issue Oct 31, 2017 · 3 comments
Open

go/importer: fix and enable TestFor for gccgo #22500

rsc opened this issue Oct 31, 2017 · 3 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@rsc
Copy link
Contributor

rsc commented Oct 31, 2017

The go command and gccgo don't get along at the moment. Once they do, importer.TestFor needs to be enabled for gccgo and checked. It may just work.
@rsc rsc added this to the Go1.10 milestone Oct 31, 2017
@andybons andybons mentioned this issue Jan 24, 2018
Closed
@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.11 Jan 31, 2018
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 31, 2018
@ianlancetaylor
Copy link
Contributor

This is nontrivial at the moment, as the test assumes it can ask for the file for math/big, but the go tool doesn't currently support that for gccgo's standard library.

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@griesemer
Copy link
Contributor

@ianlancetaylor Should this be fixable by now?

@ianlancetaylor
Copy link
Contributor

There aren't really any plans to ever make this fixable other than changing the test. The current test assumes that it can run go list -f={{context.Compiler}}:{{.Target}} math/big. gccgo doesn't provide the source code for the standard library, so go list doesn't work for standard library packages like math/big.

@griesemer griesemer modified the milestones: Go1.12, Unplanned Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@rsc @ianlancetaylor @griesemer