Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/time: update tzdata before release #22487

Open
tklauser opened this issue Oct 29, 2017 · 59 comments
Open

lib/time: update tzdata before release #22487

tklauser opened this issue Oct 29, 2017 · 59 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Milestone
Go1.23

Comments

@tklauser
Copy link
Member

tklauser commented Oct 29, 2017 •
edited by dmitshur

The timezone database in lib/time should be updated shortly before the 1.10 release (to whatever tzdata release is current then). There was https://golang.org/cl/74230 attempting to do this just now, but it was too early. @ALTree suggested to open an issue about this, so we don't forget.

The latest available version is shown at https://www.iana.org/time-zones.
@ALTree ALTree added this to the Go1.10 milestone Oct 29, 2017
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 29, 2017
@gopherbot
Copy link

Change https://golang.org/cl/74230 mentions this issue: lib/time: update tzdata to 2017c

gopherbot pushed a commit that referenced this issue Dec 6, 2017
@tklauser @bradfitz
lib/time: update tzdata to 2017c
0e76143 
Update the tzdata database to version 2017c (released 2017-10-20).

Updates #22487

Change-Id: If58ff89173ef1f1044075505f42ff132b57795f0
Reviewed-on: https://go-review.googlesource.com/74230
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz
Copy link
Contributor

bradfitz commented Jan 4, 2018

2017c is still the latest. Will regarget to Go 1.11.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Jan 4, 2018
@bradfitz bradfitz changed the title lib/time: update tzdata before 1.10 release lib/time: update tzdata before release Jan 4, 2018
@ksshannon
Copy link
Contributor

2018a came out a few days ago:

https://www.iana.org/time-zones

I'm assuming it's too late in the cycle, but just thought I'd post.

@ALTree
Copy link
Member

ALTree commented Jan 16, 2018

That's weird, they didn't even announce it in the mailing list: http://mm.icann.org/pipermail/tz-announce/

Anyway I've looked at the CHANGELOG and there are a few changes in the timezones data, here's the short version:

Release 2018a

  - São Tomé and Príncipe switched from +00 to +01.
  - Brazil's DST will now start on November's first Sunday.
  - Ireland's standard time is now in the summer, not the winter.

We could try to update it and see if anything breaks (usually it's the tests). If everything is fine, maybe it could be shipped with go1.10

@ALTree
Copy link
Member

ALTree commented Jan 16, 2018 •
edited

At the moment our update script is broken because the 2018a release is not yet published at https://data.iana.org/time-zones/releases/, which is the place we visit to download the data. Considering this (and the fact that the new release wasn't even announced in the tz-announce mailing list) we should probably wait.

@ksshannon
Copy link
Contributor

Agreed, I've downloaded the archives and make fails, so I think it may have issues.

@ksshannon
Copy link
Contributor

There was an issue with the archive, 2018b will be released in a few days:

http://mm.icann.org/pipermail/tz/2018-January/025814.html

@ksshannon
Copy link
Contributor

Another issue with 2018b, but 2018c finally made it to the announce list:

http://mm.icann.org/pipermail/tz-announce/2018-January/000048.html

@bradfitz
Copy link
Contributor

Doesn't seem worth doing this late in the cycle. @ianlancetaylor?

@ianlancetaylor
Copy link
Contributor

I have no opinion. I note that there is some disagreement going on about Irish time; I don't know how or whether that was resolved.

@gopherbot
Copy link

Change https://golang.org/cl/89375 mentions this issue: lib/time: follow redirects in curl

@ksshannon
Copy link
Contributor

ksshannon commented Jan 24, 2018 •
edited

The Irish issue was reverted. It sounded a little messy. It may just be a good idea to wait, but I have no strong opinion either. They did change the location of the archives, which the referenced CL fixes when the tree opens up.

gopherbot pushed a commit that referenced this issue Jan 24, 2018
@ksshannon @bradfitz
lib/time: follow redirects in curl
c469521 
Starting on or about the 2018c archives, www.iana.org is redirected to
data.iana.org.  Tell curl to follow the redirect.

Updates: #22487

Change-Id: I00acada1a3ba01ef701d6d4ffae6cc2cbb6a068f
Reviewed-on: https://go-review.googlesource.com/89375
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/117855 mentions this issue: lib/time: update vendored tzdata to release 2018e

gopherbot pushed a commit that referenced this issue Jun 11, 2018
@ALTree @bradfitz
lib/time: update vendored tzdata to release 2018e
bb222cd 
It has been a long time since the last time the vendored zoneinfo in
lib/time was updated, and we're well into the freeze. Update it to the
lastest release from IANA.

Updates #22487

Change-Id: Ib9a8eb409554848285fc88363dbb04ed9d6d9eb0
Reviewed-on: https://go-review.googlesource.com/117855
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@ianlancetaylor ianlancetaylor mentioned this issue Jun 15, 2018
Closed
@tklauser tklauser modified the milestones: Go1.11, Go1.12 Jul 10, 2018
@gopherbot
Copy link

Change https://golang.org/cl/151299 mentions this issue: lib/time: update tzdata to 2018g

gopherbot pushed a commit that referenced this issue Nov 28, 2018
@tklauser
lib/time: update tzdata to 2018g
3dd509d 
Now that the tree has been frozen for some time, update the tzdata
database to version 2018g (released 2018-10-26) for Go 1.12.

Updates #22487

Change-Id: I9e82bcdaef28d308643c08c9fd3472e4c14a196e
Reviewed-on: https://go-review.googlesource.com/c/151299
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@tklauser tklauser modified the milestones: Go1.12, Go1.13 Nov 28, 2018
@ksshannon
Copy link
Contributor

Just an update, there have been two more releases since 2018g, 2018i is available as of 2018-12-30:

https://www.iana.org/time-zones

@qmuntal
Copy link
Contributor

qmuntal commented Jan 30, 2023

We should also update time/zoneinfo_abbrs_windows.go when tzdata is updated so #58113 does not happen again.

Should I keep #58113 open to track the update or should it be tracked in this issue?

@dmitshur
Copy link
Contributor

@qmuntal Do you know the frequency of windowsZones.xml (the source for zoneinfo_abbrs_windows.go) changes?
If it's tied to the same tzdata release schedule at https://www.iana.org/time-zones then it makes sense to unify the two issues, but if it's a different schedule then maybe keeping the issues separate is fine.

@qmuntal
Copy link
Contributor

qmuntal commented Jan 30, 2023

windowsZones.xml is not changes frequently, last time was in May 2021. The thing is that zoneingo_abbrs_windows.go is generated mixing the data from windowsZones.xml and from tzdata, so it will probably need to be updated every time tzdata is updated, which means every release.

@mknyszek
Copy link
Contributor

According to @dmitshur it seems there's nothing left to do here for the Go 1.20 since we're already at the latest version (2022g). Moving this to the Go 1.21 milestone.

@mknyszek mknyszek modified the milestones: Go1.20, Go1.21 Jan 30, 2023
@fzipp fzipp mentioned this issue Apr 13, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/492095 mentions this issue: lib/time: update to 2023c/2023c

gopherbot pushed a commit that referenced this issue May 3, 2023
@cagedmantis
lib/time: update to 2023c/2023c
1f90bf1 
Commit generated by update.bash.

For #22487.

Change-Id: I3d5c42f5c2ed06d562aea881f75b645729e6087d
Reviewed-on: https://go-review.googlesource.com/c/go/+/492095
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@dmitshur
Copy link
Contributor

dmitshur commented Jun 7, 2023

2023c is still the latest today. Adding okay-after-rc1.

@dmitshur dmitshur added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Jun 7, 2023
@gopherbot gopherbot removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Jun 16, 2023
@rsc
Copy link
Contributor

rsc commented Jul 12, 2023

2023c is still latest per https://www.iana.org/time-zones

@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2023 •
edited

The final go1.21.0 release is scheduled for less than a week away, and 2023c is still the latest.
Moving to the next major milestone.

@dmitshur dmitshur modified the milestones: Go1.21, Go1.22 Aug 4, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Dec 1, 2023

2023c is still the latest by now. Adding okay-after-rc1. If a new version comes out before the final go1.22.0 release, we'll have a chance to update to it.

@dmitshur dmitshur added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 1, 2023
@gopherbot gopherbot removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 19, 2023
@gopherbot
Copy link

Change https://go.dev/cl/552575 mentions this issue: lib/time: update to 2023d/2023d

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Dec 22, 2023
gopherbot pushed a commit that referenced this issue Dec 26, 2023
@dmitshur @gopherbot
lib/time: update to 2023d/2023d
36a2463 
Commit generated by update.bash.

For #22487.

Change-Id: I4c8a275bb607981c21a0ad5e49b3cae968fc8e64
Reviewed-on: https://go-review.googlesource.com/c/go/+/552575
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@dmitshur dmitshur removed the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jan 3, 2024
@gopherbot
Copy link

Change https://go.dev/cl/560517 mentions this issue: lib/time: update to 2024a/2024a

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Feb 1, 2024
@mknyszek mknyszek modified the milestones: Go1.22, Go1.23 Feb 2, 2024
gopherbot pushed a commit that referenced this issue Feb 2, 2024
@dmitshur @gopherbot
lib/time: update to 2024a/2024a
6b0309c 
Commit generated by update.bash.

For #22487.

Change-Id: I1c46ec1f3a84e385f8eab2c4c9a14d3513a85a44
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/560517
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@dmitshur @ezz-no
lib/time: update to 2023d/2023d
9b88bc6 
Commit generated by update.bash.

For golang#22487.

Change-Id: I4c8a275bb607981c21a0ad5e49b3cae968fc8e64
Reviewed-on: https://go-review.googlesource.com/c/go/+/552575
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@dmitshur @ezz-no
lib/time: update to 2024a/2024a
de49705 
Commit generated by update.bash.

For golang#22487.

Change-Id: I1c46ec1f3a84e385f8eab2c4c9a14d3513a85a44
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/560517
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Projects
Release Status & Release Blockers
Status: In Progress
Milestone
Go1.23
Development

No branches or pull requests