Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/route: TestRouteMessage crashes macOS kernel #22456

Closed
rsc opened this issue Oct 26, 2017 · 2 comments
Closed

x/net/route: TestRouteMessage crashes macOS kernel #22456

rsc opened this issue Oct 26, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Oct 26, 2017

This reliably crashes the macOS kernel:

go test golang.org/x/net/route -run TestRouteMessage -count 1000000

The problem appears to be that macOS does not exactly compute the reply size correctly when reusing the request buffer. I will report that to Apple separately. A workaround for x/net is to pass in a request packet that is bigger than it really needs to be.
@rsc rsc added this to the Unreleased milestone Oct 26, 2017
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/73690 mentions this issue: route: work around macOS kernel bug

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/73691 mentions this issue: vendor/golang_org/x/net/route: refresh from upstream

gopherbot pushed a commit to golang/net that referenced this issue Oct 26, 2017
@rsc
route: work around macOS kernel bug
7b572d5 
The macOS kernel reliably crashes in a repeated TestRouteMessage.
Putting some extra padding into the request buffer avoids the crash.
This will do as workaround; the kernel bug will be reported to Apple separately.

Fixes golang/go#22456.

Change-Id: I789d3d57fbc511016d9f4a3fa7662d6c7642f137
Reviewed-on: https://go-review.googlesource.com/73690
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rsc @gopherbot