Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go vet missing vet tool's -shift flag #22442

Closed
athomason opened this issue Oct 25, 2017 · 1 comment
Closed

cmd/go: go vet missing vet tool's -shift flag #22442

athomason opened this issue Oct 25, 2017 · 1 comment

Comments

@athomason
Copy link

CL 40112 added the ability for go vet to pass through the flags that go tool vet takes. -shift was omitted in the whitelist, which seems like an oversight.

The fix is trivial, CL forthcoming.

What version of Go are you using (go version)?

go version devel +b4e207d Wed Oct 25 20:20:44 2017 +0000 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

linux/amd64

What did you do?

https://play.golang.org/p/j_a0OxUDwc

$ go tool vet -shift shift.go
shift.go:5: u (8 bits) too small for shift of 9
$ go vet -shift .
vet: flag "-shift" not defined
Run "go help vet" for more information
@gopherbot
Copy link

Change https://golang.org/cl/73553 mentions this issue: cmd/go: add -shift to go vet's flag whitelist

@golang golang locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants