Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: properly link gddo CLs to the gddo issue tracker #22428

Closed
s-mang opened this issue Oct 24, 2017 · 6 comments
Closed

x/build/cmd/gopherbot: properly link gddo CLs to the gddo issue tracker #22428

s-mang opened this issue Oct 24, 2017 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@s-mang
Copy link
Contributor

s-mang commented Oct 24, 2017

It would be nice to have gerritbot also link gddo issues (in addition to golang/go issues).

Eg. a CL with the phrase:
Updates golang/gddo#520
in the commit message should have a link to
golang/gddo#520

But it does not. The current behavior is to link to #520.
See this CL as an example:
https://go-review.googlesource.com/c/gddo/+/73031

If this is deemed unnecessary, we should at least remove the link to the #520.

cc @andybons @shantuo
@gopherbot gopherbot added this to the Unreleased milestone Oct 24, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 24, 2017
@ghost
Copy link

ghost commented Oct 25, 2017

https://go-review.googlesource.com/c/gddo/+/73031

https://go-review.googlesource.com/c/oauth2/+/24946

Try saving the above webpages, run a grep for 520 on the former, for 11811 on the latter, and see what happens.

@ghost
Copy link

ghost commented Oct 25, 2017 •
edited by ghost
Loading

CC @bradfitz

As you're the Owner of the 2nd CL in the last Comment perhaps you would be inclined to chip in.

cf: https://github.com/golang/scratch/issues/1

The scratch sub-repository by the way has a dummy issue.

Below is a presumed accurate list of sub-repositories, those with an Issues tab are marked.

☐ sys
☒ dep
☐ build
☐ tools
☐ crypto
☐ proposal
☐ text
☐ net
☐ mobile
☒ scratch
☒ protobuf
☒ oauth2
☐ gofrontend
☒ mock
☒ tour
☐ blog
☒ gddo
☒ lint
☐ image
☒ appengine
☐ review
☒ cwg
☐ arch
☐ exp
☐ time
☐ term
☐ sync
☐ perf
☒ geo
☐ playground
☐ debug
☐ example
☒ snappy
☒ groupcache
☐ talks
☐ glog
☒ freetype
☒ sublime-build
☐ benchmarks
☒ leveldb
☒ winstrap
☒ sublime-config

@andybons
Copy link
Member

The scratch sub-repository by the way has a dummy issue.

This is OK as the scratch repo is used for testing with our infrastructure in some cases.

@ghost
Copy link

ghost commented Oct 25, 2017

@andybons

https://help.github.com/articles/disabling-issues/

So the presumption is that for the unmarked subrepos that issues have been turned off.

@kevinburke
Copy link
Contributor

This is a dupe of #21072.

@s-mang
Copy link
Contributor Author

s-mang commented Oct 25, 2017

Thanks Kevin

@s-mang s-mang closed this as completed Oct 25, 2017
@ghost ghost mentioned this issue Oct 26, 2017
Open
@golang golang locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@kevinburke @andybons @s-mang @gopherbot