Skip to content

go/types: WriteExpr doc is misleading #22377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
willfaught opened this issue Oct 21, 2017 · 1 comment
Closed

go/types: WriteExpr doc is misleading #22377

willfaught opened this issue Oct 21, 2017 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Go1.10

Comments

@willfaught
Copy link
Contributor

willfaught commented Oct 21, 2017 •
edited
Loading

It says:

// WriteExpr writes the (possibly simplified) string representation for x to buf.

"Simplified" suggests merely reducing expressions in size where equivalent. Instead, it means not writing valid syntax.

What did you do?

https://play.golang.org/p/9_CJWdUEAv

What did you expect to see?

func() {}

What did you see instead?

(func() literal)

System details

go version go1.9.1 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/willfaught/Developer/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.9.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.9.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_1/ggvd2t1x7hz_185crsb36zlr0000gp/T/go-build370620436=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version go1.9.1 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.9.1
uname -v: Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.12.6
BuildVersion:	16G29
lldb --version: lldb-900.0.50.1
  Swift-4.0
@ianlancetaylor ianlancetaylor added the Documentation Issues describing a change to documentation. label Oct 23, 2017
@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Oct 23, 2017
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/72690 mentions this issue: go/types: improved documentation for WriteExpr and ExprString

@golang golang locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@willfaught @ianlancetaylor @griesemer @gopherbot