Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: enable TestNoteReading on ppc64x #22360

Closed
mundaym opened this issue Oct 20, 2017 · 3 comments
Closed

cmd/go: enable TestNoteReading on ppc64x #22360

mundaym opened this issue Oct 20, 2017 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mundaym
Copy link
Member

mundaym commented Oct 20, 2017

Part of TestNoteReading is disabled on ppc64 and ppc64le but the issue it links to is now closed (#11184).

I think TestNoteReading should now be fully enabled on ppc64le. If ppc64 doesn't work yet (not clear from the issue) we should probably change the issue number it references.

@mundaym mundaym added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 20, 2017
@mundaym mundaym added this to the Go1.10 milestone Oct 20, 2017
@mundaym
Copy link
Member Author

mundaym commented Oct 20, 2017

/cc @laboger @ceseo

@laboger
Copy link
Contributor

laboger commented Oct 25, 2017

ppc64le has external linking, ppc64 does not. I'll try enabling it for ppc64le.

@gopherbot
Copy link

Change https://golang.org/cl/73510 mentions this issue: cmd/go: enable TestNoteReading on ppc64le

@golang golang locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants