Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/ssh: banner support update breaks connectivity #22359

Closed
paultyng opened this issue Oct 20, 2017 · 3 comments
Closed

crypto/ssh: banner support update breaks connectivity #22359

paultyng opened this issue Oct 20, 2017 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@paultyng
Copy link

paultyng commented Oct 20, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.8.3

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

linux / amd64

What did you do?

Connect via ssh to SFTP server.

Configuration code as follows:

conn, err := ssh.Dial("tcp", addr, &ssh.ClientConfig{
  User: username,
  Auth: []ssh.AuthMethod{
    ssh.Password(password),
  },
  HostKeyCallback: ssh.InsecureIgnoreHostKey(),
})

What did you expect to see?

No error

What did you see instead?

When I upgrade to the most recent commit of golang/crypto@ed5229d on the SSH package, I started getting errors when connecting to my SSH server using Password authentication.

Only tried against my existing server, but server version is SSH-2.0-1.82_sshlib Globalscape

Code errors out with ssh: handshake failed: ssh: parse error in message type 53

As soon as I roll back to the previous commit, it succeeds.

@ALTree
Copy link
Member

ALTree commented Oct 20, 2017

Something similar was also reported this morning, here: #19567 (comment)

cc @tucksaun @hanwen

@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 20, 2017
@ALTree ALTree changed the title crypto/ssh - banner support update breaks connectivity crypto/ssh: banner support update breaks connectivity Oct 20, 2017
@ALTree ALTree added this to the Unreleased milestone Oct 20, 2017
@gopherbot
Copy link

Change https://golang.org/cl/71790 mentions this issue: ssh: fix parse error in message for banners

@hanwen
Copy link
Contributor

hanwen commented Nov 8, 2017

the change has been rolled back in 2509b14

@hanwen hanwen closed this as completed Nov 8, 2017
@golang golang locked and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants