Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net: Update "net/context" documentation to point to context package #22322

Closed
frojasg opened this issue Oct 18, 2017 · 2 comments
Closed

x/net: Update "net/context" documentation to point to context package #22322

frojasg opened this issue Oct 18, 2017 · 2 comments
Labels
Documentation FrozenDueToAge
Milestone
Unreleased

Comments

@frojasg
Copy link
Contributor

frojasg commented Oct 18, 2017

I was trying to figure out the difference between the "golang.org/x/net/context" and "context, " and I couldn't find any, so I was a little bit confused. I had to dig into the release notes until I saw the release notes for 1.7 where it says:

Go 1.7 moves the golang.org/x/net/context package into the standard library as context.

It would be helpful to update the doc in "x/net/context" to point to the release note. Also, I notice that go tool fix help you to change imports of golang.org/x/net/context to context. It would be cool to reference that too.

I would be happy to help with a patch if you think is worth it.
@gopherbot gopherbot added this to the Unreleased milestone Oct 18, 2017
@ianlancetaylor
Copy link
Contributor

Yes, it's worth it. I don't think you should point to the release note; that is no longer particularly interesting. You should just say something like "as of Go 1.7 this package is available in the standard library under the name context" and point to golang.org/pkg/context. Thanks.

@gopherbot
Copy link

Change https://golang.org/cl/72570 mentions this issue: x/net: Update documentation with Go 1.7 changes

@golang golang locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@frojasg @ianlancetaylor @gopherbot