Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/smtp: add Noop function #22321

Closed
cryptix opened this issue Oct 18, 2017 · 3 comments
Closed

net/smtp: add Noop function #22321

cryptix opened this issue Oct 18, 2017 · 3 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@cryptix
Copy link

cryptix commented Oct 18, 2017

Hi,

I want to add the NOOP command to the smtp client.

I think it would be good to have this to check the status of a client connection.

It looks like a simple addition and I'd be willing to contribute this myself.

One thing I'm not sure about is how to test this. The examples use smtp.example.com but I don't think this is really functional?
@gopherbot
Copy link

Change https://golang.org/cl/71650 mentions this issue: net/smtp: added Noop to Client

@ianlancetaylor
Copy link
Contributor

For testing, see net/mail/smtp_test.go and the serverHandle function.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Oct 18, 2017
@ianlancetaylor ianlancetaylor changed the title add Noop() to net/smtp net/smtp: add Noop function Oct 18, 2017
@ianlancetaylor
Copy link
Contributor

Sorry, I said net/mail/smtp_test.go but of course I meant net/smtp/smtp_test.go.

@cryptix cryptix mentioned this issue Dec 10, 2017
Open
@golang golang locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@cryptix @ianlancetaylor @gopherbot