Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestLldbPython test fails with lldb 3.8 on linux #22299

Open
hyangah opened this issue Oct 16, 2017 · 4 comments
Open

runtime: TestLldbPython test fails with lldb 3.8 on linux #22299

hyangah opened this issue Oct 16, 2017 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 16, 2017

Verified the test passed with lldb 3.9 or higher, or if lldb is not installed at all.

--- FAIL: TestLldbPython (1.83s)
runtime-lldb_test.go:178: Unexpected lldb output:
Created target
Created breakpoint
Process launched
Hit breakpoint
Stopped at main.go:10
Stopped in main.main
no intvar
FAIL
FAIL runtime 19.046s

Skipping the test if lldb is too ancient seems reasonable.
@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Oct 16, 2017
@ianlancetaylor ianlancetaylor added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Oct 16, 2017
@mvdan
Copy link
Member

mvdan commented Oct 29, 2017

The lldb tests are already skipped if it or python are not available. Would an additional version check to ensure version 3.9 or later is available be an OK fix for this?

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jul 7, 2018
@ianlancetaylor
Copy link
Contributor

Yes, checking the lldb version sounds like a good fix.

@gopherbot
Copy link

Change https://golang.org/cl/139397 mentions this issue: runtime: skip TestLldbPython when lldb is too old

@ALTree
Copy link
Member

ALTree commented Oct 5, 2018

FIx was reverted: https://go-review.googlesource.com/c/go/+/140217

@ALTree ALTree reopened this Oct 5, 2018
@agnivade agnivade mentioned this issue Dec 14, 2018
Closed
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
7 participants
@rsc @andybons @ianlancetaylor @mvdan @ALTree @hyangah @gopherbot