Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: windows tests fail due to changes to getmac [Go 1.8] #22276

Closed
rsc opened this issue Oct 15, 2017 · 3 comments
Closed

net: windows tests fail due to changes to getmac [Go 1.8] #22276

rsc opened this issue Oct 15, 2017 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.8.5

Comments

@rsc
Copy link
Contributor

rsc commented Oct 15, 2017

This was fixed in the Go 1.9 cycle and should be backported to make trybots happy when preparing point releases.
@rsc rsc added this to the Go1.8.5 milestone Oct 15, 2017
@rsc
Copy link
Contributor Author

rsc commented Oct 15, 2017

CL 41395 OK for Go 1.8.5.

@rsc rsc added the CherryPickApproved Used during the release process for point releases label Oct 15, 2017
@rsc rsc mentioned this issue Oct 15, 2017
Closed
@odeke-em
Copy link
Member

Hehe, great filing this issue @rsc, getmac was giving the trybots hell when I ran them against your go1.8* release branches until we noticed the problem.

@rsc
Copy link
Contributor Author

rsc commented Oct 26, 2017

go1.8.5 has been packaged and includes:

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:07:52 UTC

@rsc rsc closed this as completed Oct 26, 2017
@golang golang locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.8.5
Development

No branches or pull requests
3 participants
@rsc @odeke-em @gopherbot