Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: build.golang.org should link to Gerrit, not GitHub commits #22217

Closed
rsc opened this issue Oct 11, 2017 · 4 comments
Closed

x/build: build.golang.org should link to Gerrit, not GitHub commits #22217

rsc opened this issue Oct 11, 2017 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Oct 11, 2017

The left column of build.golang.org has Git commit hashes, and it links to

https://github.com/golang/go/commit/<COMMIT>

But all of us most commonly use Gerrit to view commits. We should probably do the same here. The URL should change to

https://go-review.googlesource.com/q/<COMMIT>

Not sure who, if anyone, is in charge of build.golang.org these days.

/cc @andybons @adams-sarah
@rsc rsc added this to the Unreleased milestone Oct 11, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 11, 2017
@s-mang
Copy link
Contributor

s-mang commented Oct 11, 2017

I am responsible for fixing builder bugs. Features I'm pushing out 'til @bradfitz gets back. Lack of time.
Maybe Andy can take this.

@andybons andybons self-assigned this Oct 11, 2017
@gopherbot
Copy link

Change https://golang.org/cl/70170 mentions this issue: x/build: link to Gerrit changes instead of GitHub commits

@s-mang
Copy link
Contributor

s-mang commented Oct 11, 2017

Thanks Andy.

@andybons
Copy link
Member

This has been deployed to build.golang.org.

There is a bug where going back from the Gerrit change page via this shortcut is broken, but a fix for that was also submitted (https://gerrit-review.googlesource.com/132930) and should be live whenever Gerrit deploys next (week or two?).

@golang golang locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @andybons @s-mang @gopherbot