Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/cmd/gotype: Now considers C.int an invalid type #22090

Closed
jmunson opened this issue Sep 29, 2017 · 9 comments
Closed

x/cmd/gotype: Now considers C.int an invalid type #22090

jmunson opened this issue Sep 29, 2017 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.10

Comments

@jmunson
Copy link

jmunson commented Sep 29, 2017

It appears that in go1.9, gotypes now handles C.int differently than it did in previous versions, now producing an invalid type error.

What version of Go are you using (go version)?

go version go1.9 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

arch linux amd64

What did you do?

❯go get github.com/mattn/go-sqlite3
❯ gotype ~/go/src/github.com/mattn/go-sqlite3/

What did you expect to see?

No type errors, as was the case with go1.8.3

What did you see instead?

/home/jmunson/go/src/github.com/mattn/go-sqlite3/error.go:14:17: invalid constant type invalid type
@gopherbot gopherbot added this to the Unreleased milestone Sep 29, 2017
@ianlancetaylor
Copy link
Contributor

CC @griesemer

@griesemer griesemer self-assigned this Oct 4, 2017
@griesemer
Copy link
Contributor

Before I dive into this, could you please check and let me know if there's a difference when you run gotype with the -c=gc option? (This was the default in the past, now it's -c=source.) Thanks.

@mjtrangoni
Copy link

@griesemer I have the same problems with go1.9.1

$ gotype -c=source vendor/github.com/mattn/go-sqlite3/error.go
vendor/github.com/mattn/go-sqlite3/error.go:16:17: invalid constant type invalid type
vendor/github.com/mattn/go-sqlite3/error.go:80:9: undeclared name: errorString
$ gotype -c=gc vendor/github.com/mattn/go-sqlite3/error.go
vendor/github.com/mattn/go-sqlite3/error.go:16:17: invalid constant type invalid type
vendor/github.com/mattn/go-sqlite3/error.go:80:9: undeclared name: errorString```

@JC1738
Copy link

JC1738 commented Dec 9, 2017

See the same issue with github.com/mattn/go-sqlite3 on

go version go1.9.2 linux/amd64

@griesemer griesemer modified the milestones: Unreleased, Go1.11 Dec 9, 2017
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 9, 2017
@ysqi
Copy link

ysqi commented Dec 19, 2017

go build is ok, get error under go generate :

stringer: checking package: database.go:31:2: could not import MYProject/db 
(type-checking package "****/db" failed 
(***db.go:16:4: could not import github.com/mattn/go-sqlite3 (type-checking package "***/vendor/github.com/mattn/go-sqlite3" failed 
(/***/vendor/github.com/mattn/go-sqlite3/error.go:14:17: invalid constant type invalid type))))
***/net.go:825: running "stringer": exit status 1

@aletheia7
Copy link

gotype o.go produces

o.go:50:11: invalid constant type Login

for this code:

type Login C.odbUSHORT                                                                                                                                                                                               
                                                                                                                                                                                                                     
const (                                                                                                                                                                                                              
    Normal   Login = C.ODB_LOGIN_NORMAL                                                                                                                                                                              
    Reserved       = C.ODB_LOGIN_RESERVED                                                                                                                                                                            
    Single         = C.ODB_LOGIN_SINGLE                                                                                                                                                                              
)

These constants compile fine.

gotype is used by stringer. stringer fails to parse constants because of gotype.

@griesemer
Copy link
Contributor

Simple reproducer for the issues with github.com/mattn/go-sqlite3:

package p

import "C"
import "unsafe"

const _ C.int = 0xff

type T struct {
	Name    string
	Ordinal int
}

func f(args []T) {
	var s string
	for i, v := range args {
		cname := C.CString(v.Name)
		args[i].Ordinal = int(C.sqlite3_bind_parameter_index(s, cname))
		C.free(unsafe.Pointer(cname))
	}
}

gotype reports:

x.go:8:9: invalid constant type invalid type
x.go:17:6: i declared but not used

At least the first error is trivial to fix (CL forthcoming).

@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 19, 2018
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 19, 2018
@gopherbot
Copy link

Change https://golang.org/cl/88375 mentions this issue: go/types: more robust behavior in the presence errors (cause by C objects)

@griesemer griesemer modified the milestones: Go1.11, Go1.10 Jan 23, 2018
@griesemer
Copy link
Contributor

Changed milestone to Go1.10 per discussion with @ianlancetaylor .

@rmmh rmmh mentioned this issue Feb 6, 2018
Closed
@golang golang locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
8 participants
@jmunson @mjtrangoni @ysqi @ianlancetaylor @JC1738 @aletheia7 @griesemer @gopherbot