Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: nil (*GerritCL).Meta when it shouldn't be #22060

Closed
judepereira opened this issue Sep 27, 2017 · 10 comments
Closed

x/build/maintner: nil (*GerritCL).Meta when it shouldn't be #22060

judepereira opened this issue Sep 27, 2017 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@judepereira
Copy link

judepereira commented Sep 27, 2017 •
edited

While iterating through the Corpus, I've encountered two GerritCLs where the their Meta field is empty:

{
  Project:0xc42f6d0f50 
  Number:44072
  Created:0001-01-01 00:00:00 +0000 UTC
  Version:1
  Commit:{GitCommit 993bdcf6e6a7cf7c4b742349b6d28dd4de3359b8}
  Meta:<nil *GitCommit>
  MetaCommits:[]
  Status: 
  GitHubIssueRefs:[]
  Messages:[]
}

{
  Project:0xc42f6d0f50
  Number:44073
  Created:0001-01-01 00:00:00 +0000 UTC
  Version:1
  Commit:{GitCommit 73004ad04bc0d0786977c27e205d6e3801daafe3}
  Meta:<nil *GitCommit>
  MetaCommits:[]
  Status:
  GitHubIssueRefs:[]
  Messages:[]
}

Moreover, I cannot find these two CLs either: 44072 and 44073.

/cc @kevinburke @bradfitz
@gopherbot gopherbot added this to the Unreleased milestone Sep 27, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 27, 2017
@s-mang
Copy link
Contributor

s-mang commented Sep 29, 2017

I would think these two CLs have just been abandoned and purged from the Gerrit DB for some reason.
The timestamps are both 0.
Neither of the two commit SHAs are in the go project tree.
And CL 44071 and 44074 are both from around 4 months ago.

Are you seeing failures of some kind? I can't think of any negative consequences of this. @judepereira

@s-mang
Copy link
Contributor

s-mang commented Sep 29, 2017

Related to #21984

@judepereira
Copy link
Author

I came across this while fixing cmd/cl. Hence thought I'd put it up here to see if somebody knew anything about it.

If it's a no-op, then we can close this.

@bradfitz
Copy link
Contributor

We should do something here. At least understand what happened in the mutation log and add some docs if nothing else before closing this.

@judepereira
Copy link
Author

@bradfitz, any pointers on diving into the mutation logs?

@bradfitz
Copy link
Contributor

bradfitz commented Nov 2, 2017

@judepereira, I don't understand the question.

The logs are at http://maintner.golang.org/logs

I imagine there was a bug in the past that caused such log entries to be created. To close this bug, I'd at least document that it may be nil, but ideally we'd also understand when this bug was introduced and (hopefully) fixed.

@judepereira
Copy link
Author

@bradfitz, I meant pointers on how to find the cause of this, as there's no date info that's available (can't really pin point when it happened).

@judepereira
Copy link
Author

I can document that this field can be nil though.

@kevinburke
Copy link
Contributor

kevinburke commented Nov 4, 2017 via email

@billotosyr billotosyr mentioned this issue Apr 9, 2018
Closed
@bradfitz bradfitz mentioned this issue Apr 15, 2018
Closed
@bradfitz bradfitz self-assigned this Apr 15, 2018
@gopherbot
Copy link

Change https://golang.org/cl/107296 mentions this issue: maintner: change type/name of GerritCL meta fields, ensure Meta always non-nil

@golang golang locked and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @kevinburke @judepereira @s-mang @gopherbot