Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive/tar: unnecessary zero-byte Read requests #22029

Closed
rogpeppe opened this issue Sep 25, 2017 · 2 comments
Closed

archive/tar: unnecessary zero-byte Read requests #22029

rogpeppe opened this issue Sep 25, 2017 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.10

Comments

@rogpeppe
Copy link
Contributor

go version devel +6171d05 Sat Sep 23 09:24:02 2017 +0000 linux/amd64

Since https://go-review.googlesource.com/56771, archive/tar can issue zero
byte read requests. This can result in regressions with readers that do not
support zero-byte reads well (see issue #22028 for an example).
@dsnet dsnet self-assigned this Sep 25, 2017
@dsnet dsnet added this to the Go1.10 milestone Sep 25, 2017
@rogpeppe
Copy link
Contributor Author

Here is an example of a program that fails now that didn't before.
https://play.golang.org/p/RtUpyQw2CZ
(this exposes the long-standing bug in compress/bzip2: #22028)

@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 25, 2017
@gopherbot
Copy link

Change https://golang.org/cl/66111 mentions this issue: archive/tar: avoid empty IO operations

@golang golang locked and limited conversation to collaborators Sep 25, 2018
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@rogpeppe @ianlancetaylor @dsnet @gopherbot