New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: diagnostics document: additional questions and proposed changes #22027
Comments
/cc @rakyll |
Change https://golang.org/cl/83916 mentions this issue: |
Change https://golang.org/cl/83917 mentions this issue: |
Updates #22027. Change-Id: I468348d2b000f146f88ef8b7cf450eea8d1c12a7 Reviewed-on: https://go-review.googlesource.com/83917 Reviewed-by: Andrew Bonventre <andybons@golang.org>
Updates #22027. Change-Id: I5a5bae77a744c7a2ecb75172846e6461a98ee8af Reviewed-on: https://go-review.googlesource.com/83916 Reviewed-by: Andrew Bonventre <andybons@golang.org>
The answer is not always very obvious and might require some more than just a few lines. I do not think diagnostics page is the best place to give further advice. I will try to write a Go blog post instead. All of the other concerns are addressed in the CLs. |
Thank you for putting together the diagnostics document, it is very useful for us people who's starting working with Go.
I'm creating this issue as I've additional doubts and @rakyll pointed me to here to ask for clarifications.
In the profiling section you have answered if it's possible to profile production services: I'm going to copy the answer here and add bold to the additional doubts that I have about it:
This answer is very clear and concise, yet I've found myself trying to answer an additional question: how do one measure the overhead of the profiler? What do you mean by replicas, multiple copies of the same process running in the same machine?
I am guessing the answer might be obvious and it's escaping me due to my lack of enough experience, but I think that additional details like these could really improve the document.
Another question that I have was when reading about serving the profiler handlers in different path and port. The example used is:
However when I went to the
net/http/pprof
documentation I couldn't find a reference topprof.Profile
but rather I had to go to read theinit
function of that package to find how to do it. Am I missing something or is it just a bug in the document?I've also found some package mentions like
context.Context
andhttptrace.ClientTrace
that don't provide a link to the documentation, which I think could be more than useful.Sorry for the length of this issue, and if the answers are simple yet eluding me. Thank you for taking the time to read it! I would like to become a Go contributor someday so I'm more than willing to make changes to this document, provided I find out how to answer these questions 😺
The text was updated successfully, but these errors were encountered: