Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/macho: parse relocations #21957

Closed
hirochachacha opened this issue Sep 21, 2017 · 4 comments
Closed

debug/macho: parse relocations #21957

hirochachacha opened this issue Sep 21, 2017 · 4 comments
Labels
FrozenDueToAge

Comments

@hirochachacha
Copy link
Contributor

I want to debug some relocations. Current library doesn't parse relocations.
So, users have to parse relocations themselves. It would be nice to add these feature in the standard library. debug/pe already have same feature.
@gopherbot
Copy link

Change https://golang.org/cl/65150 mentions this issue: debug/macho: parse relocations

@hirochachacha
Copy link
Contributor Author

Hmm, I'm not sure that whether this change is conformance with Go1.0 compatibility rule.

@alexbrainman
Copy link
Member

I'm not sure that whether this change is conformance with Go1.0 compatibility rule.

I think your change is fine - you are adding new macho.Reloc type and Relocs filed to existing macho.Section. I did something similar to debug/pe before.

I just need to make sure your new additions are good to stay, because you won't be able to change them after go1.10 is released.

Alex

@hirochachacha
Copy link
Contributor Author

hirochachacha commented Sep 21, 2017 •
edited

Thanks! I'll be careful.

@golang golang locked and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hirochachacha @gopherbot @alexbrainman