Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: database/sql: support default valueConverter per driver #21930

Closed
bgaifullin opened this issue Sep 19, 2017 · 3 comments
Closed

proposal: database/sql: support default valueConverter per driver #21930

bgaifullin opened this issue Sep 19, 2017 · 3 comments
Labels
FrozenDueToAge Proposal
Milestone
Proposal

Comments

@bgaifullin
Copy link
Contributor

I want to use type []T in ExecerContext and QueryerContext since clickhouse implements support for array, but I cannot not, because database/sql does not allow me pass this type to driver.

I want to specify custom ValueConverter in my driver, which will be used instead of defaultValueConverter in func (db *DB) QueryContext and func (db *DB) ExecContext

clickhouse driver: https://github.com/mailru/go-clickhouse
@gopherbot gopherbot added this to the Proposal milestone Sep 19, 2017
@rsc
Copy link
Contributor

rsc commented Sep 25, 2017

/cc @bradfitz @kardianos

@kardianos
Copy link
Contributor

The driver should implement https://godoc.org/database/sql/driver#NamedValueChecker (added as of go1.9).

@bgaifullin
Copy link
Contributor Author

Thanks

@golang golang locked and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
4 participants
@rsc @kardianos @bgaifullin @gopherbot