-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: net/http2: support proxy/socks for Client #21907
Comments
CC @tombergan |
Thank you for the request @packman80. For starters, could you please provide a code snippet reproducing what wasn't working? Also your Go version? |
It's about http2 client (net/http2). net/http has support proxy/socks in transport.go, but net/http2 (no implemented methods in transport.go) doesn't support it. I edited title. |
Can you explain why you need to use SOCKS with x/net/http2 instead of net/http? SOCKS is not part of HTTP/2 so I would lean towards not adding support there unless there is a good motivating use case. Also, can you clarify whether you are talking about SOCKS or CONNECT? |
Ping @packman80, can you reply to @tombergan's questions above? Thanks. |
We believe that when you use HTTP2 via net/http, which is the suggested way, then the $HTTP_PROXY environment variable is respected and socks works fine as a way to create new connections to specific hosts (and then net/http runs HTTP2 over those as possible). Given lack of response above, closing. |
Go has great http2 client, but it doesn't work through proxy/socks at all. Please, add it in further versions.
The text was updated successfully, but these errors were encountered: