Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container/heap: use t.Helper() in verify #21863

Closed
tbpg opened this issue Sep 13, 2017 · 1 comment
Closed

container/heap: use t.Helper() in verify #21863

tbpg opened this issue Sep 13, 2017 · 1 comment

Comments

@tbpg
Copy link
Contributor

tbpg commented Sep 13, 2017

What version of Go are you using (go version)?

go version go1.9 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"

What did you do?

I read https://golang.org/src/container/heap/heap_test.go.

What did you expect to see?

I expected verify() to use t.Helper(), making test failures print the line of the call to verify().

What did you see instead?

Failures print the line where t.Errorf() was called.

@gopherbot
Copy link

Change https://golang.org/cl/63570 mentions this issue: container/heap: call t.Helper() in verify()

@golang golang locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants