runtime: lost non-Go profiling samples are overcounted #21836
Labels
CherryPickApproved
Used during the release process for point releases
FrozenDueToAge
release-blocker
Milestone
Comments
|
Change https://golang.org/cl/63270 mentions this issue: |
|
Change https://golang.org/cl/63310 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Sep 12, 2017
…ra to 0 after flush After the number of lost extra events are written to the the cpuprof log, the number of lost extra events should be set to zero, or else, the next time time addExtra is logged, lostExtra will be overcounted. This change resets lostExtra after its value is written to the log. Fixes #21836 Change-Id: I8a6ac9c61e579e7a5ca7bdb0f3463f8ae8b9f863 Reviewed-on: https://go-review.googlesource.com/63270 Reviewed-by: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 96b1eff) Reviewed-on: https://go-review.googlesource.com/63310 Run-TryBot: Ian Lance Taylor <iant@golang.org>
|
|
rsc
added
the
CherryPickApproved
|
Change https://golang.org/cl/70974 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Oct 25, 2017
…ra to 0 after flush After the number of lost extra events are written to the the cpuprof log, the number of lost extra events should be set to zero, or else, the next time time addExtra is logged, lostExtra will be overcounted. This change resets lostExtra after its value is written to the log. Fixes #21836 Change-Id: I8a6ac9c61e579e7a5ca7bdb0f3463f8ae8b9f864 Reviewed-on: https://go-review.googlesource.com/63270 Reviewed-by: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/70974 Run-TryBot: Russ Cox <rsc@golang.org>
|
go1.9.2 has been packaged and includes: The release is posted at golang.org/dl. — golang.org/x/build/cmd/releasebot, Oct 26 21:09:14 UTC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
cpuProfile.addExtra is called from the Go profiling signal handler to flush any accumulated non-Go profiling samples. If we lost any non-Go profiling samples, it flushes this as a special
_LostExternalCodesample. However, it fails to reset the lost sample count, so every subsequentaddExtracall will record another_LostExternalCodesample.This fix should be as simple as setting
p.lostExtrato 0, but this should get back-ported to 1.9.1./cc @ianlancetaylor @matloob
The text was updated successfully, but these errors were encountered: