Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: consistent, documented deployment strategies for all kube binaries #21772

Closed
s-mang opened this issue Sep 5, 2017 · 1 comment
Closed
Labels
Builders x/build issues (builders, bots, dashboards) Documentation FrozenDueToAge
Milestone

Comments

@s-mang
Copy link
Contributor

s-mang commented Sep 5, 2017

there's no real, consistent or documented deployment approach for kube binaries.
not critical, but good to keep everything consistent. less divergence == happy maintainer.

let's modify Makefiles such that they adhere to the following pattern:

deploy-prod: push-prod
	kubectl set image deployment/$(BINARY_NAME)-deployment $(BINARY_NAME)=gcr.io/symbolic-datum-552/$(BINARY_NAME):$(VERSION)

this pattern already present in pubsubhelper, devapp.

ensure:
coordinator, gitmirror, gopherbot, maintner, scaleway, ... (did I miss any?)

@gopherbot gopherbot added this to the Unreleased milestone Sep 5, 2017
@gopherbot gopherbot added Builders x/build issues (builders, bots, dashboards) Documentation labels Sep 5, 2017
@gopherbot
Copy link

Change https://golang.org/cl/61730 mentions this issue: all: normalize GKE configs/Makefiles to follow common patterns

@golang golang locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) Documentation FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants