proposal: log: flush output on Fatal and Panic methods if the destination writer has a Flush method #21751
Labels
Milestone
Comments
odeke-em
changed the title
|
@rgooch I've made a code sample that can help support your proposal with a repro at https://github.com/odeke-em/bugs/tree/master/golang/21751 or https://play.golang.org/p/V2Cz3q1AN1 or inlined below package main
import (
"bufio"
"flag"
"log"
"os"
"strings"
)
func main() {
var flush bool
flag.BoolVar(&flush, "flush", false, "if set, will flush the buffered io before exiting")
flag.Parse()
br := bufio.NewWriter(os.Stdout)
logger := log.New(br, "", log.Ldate)
logger.Printf("%s\n", strings.Repeat("This is a test\n", 5))
if flush {
br.Flush()
}
logger.Fatalf("exiting now!")
}Without invoking flush -- the problem illustrated$ echo -e "\033[32mCommon case, flush not invoked before Fatalf\033[00m" && go run main.go
Common case, flush not invoked before Fatalf
exit status 1With flush invoked -- the manual way, illustrating the solution$ echo -e "\033[32mSupporting case, flush invoked before Fatalf\033[00m" && go run main.go --flush
Supporting case, flush invoked before Fatalf
2017/09/03 This is a test
This is a test
This is a test
This is a test
This is a test
exit status 1 |
|
Thanks. Note how the "exiting now!" message is not displayed in either test, which shows that the solution is needed inside the log package, since even if the application performs a |
|
Totally! |
|
This can't work. If you have a bufio writing to a gzip writing to an os.File, flushing the bufio will not flush the gzip and so will not actually put any of the log message into the file. This is by design - Flush doesn't chain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If the output destination for a logger is buffered, a call to one of the
Fatalmethods can lose logs, becauseos.Exitis called immediately after logging, likely before the buffer is flushed. To fix this, if the destination writer has aFlushmethod, then call it. Example implementation:type flusher interface {
Flush() error
}
func (l *Logger) Fatal(v ...interface{}) {
l.Output(2, fmt.Sprint(v...))
if fl, ok := l.out.(flusher); ok {
fl.Flush()
}
os.Exit(1)
}
The
Panicmethods suffer from the same loss of logs, sincepanicis called immediately after logging, prior to the buffer being flushed. This can be solved in a similar way, callingFlushprior to callingpanic.The text was updated successfully, but these errors were encountered: