Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: congratulate new contributors based on unique email only #21731

Closed
kevinburke opened this issue Sep 1, 2017 · 1 comment
Closed

x/build/cmd/gopherbot: congratulate new contributors based on unique email only #21731

kevinburke opened this issue Sep 1, 2017 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@kevinburke
Copy link
Contributor

We've had several cases where users have slightly changed the name they use for their git commits, triggering the "Congratulations on your first change..." bot. CL https://go-review.googlesource.com/60851 is a good example of this. We should probably just have it be unique by email address.

The code is here: https://github.com/golang/build/blob/master/cmd/gopherbot/gopherbot.go#L782

I think this would be a good change for new contributors to the Go tools.
@kevinburke kevinburke added Builders x/build issues (builders, bots, dashboards) help wanted labels Sep 1, 2017
@gopherbot gopherbot added this to the Unreleased milestone Sep 1, 2017
@gopherbot
Copy link

Change https://golang.org/cl/61030 mentions this issue: gopherbot: changed congratulateNewContributors to use email as

@golang golang locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@kevinburke @gopherbot