Skip to content

mime: ParseMediaType new tests that expects different return #21683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guilhermebr opened this issue Aug 29, 2017 · 0 comments
Closed

mime: ParseMediaType new tests that expects different return #21683

guilhermebr opened this issue Aug 29, 2017 · 0 comments

Comments

@guilhermebr
Copy link
Contributor

guilhermebr commented Aug 29, 2017

I created a change (https://go-review.googlesource.com/c/go/+/59950)
that adds missing tests from http://greenbytes.de/tech/tc2231/
(see this TODO: https://github.com/golang/go/blob/master/src/mime/mediatype_test.go#L142)

But there are 5 tests who I not included from this site because expects a different return that is currently returned by ParseMediaType function, and I don't know if is better to fix this or not...

Four of them is related to backslash escape:

And the last is about putting encode inside quotes:

https://play.golang.org/p/wMsDdfBeh3

@golang golang locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants
@guilhermebr @gopherbot and others