New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add checksum for go1.4-bootstrap #21662
Comments
FWIW, it's available at https://storage.googleapis.com/golang/go1.4-bootstrap-20170531.tar.gz.sha256 |
There's also a GPG signature for every tar.gz download. "...tar.gz.asc" |
In a 29-08-17 dated reply to an e-mail to security [at] golang [dot] org, @rsc wrote "We should probably get the bootstrap tar.gz listed on golang.org/dl, which already has checksums." https://golang.org/doc/install/source In the event that any additional fixes are added to go1.4-bootstrap, then the SHA256 Checksum provided by @nehaljwani would (of consequence) no longer be valid. https://golang.org/dl/#featured Under "Featured downloads" there is factually room for an additonal 'Bootstrap' button. Under "Stable versions" could be then be added a 'go1.4-bootstrap' section, with the most recent bootstrap accompanying its valid SHA256 Checksum. |
Please don't add a |
It appears there are two sections with anchors on golang.org/dl, so rejecting the added Button as per the comment of @ALTree, would the Parties involved in this thread, then be amenable to having a third "Bootstrap" section with an anchor, thereunder an expandable go1.4 subsection, and then modifying the bootstrap tar.gz link on golang.org/doc/install/source to point to that new anchor, where clicking on that modified link would open the page in a new browser tab? |
if https://golang.org/doc/install/source is to be edited https://forum.golangbridge.org/t/compiling-go-cgo-enabled/6858 https://golang.org/doc/install/source#ccompiler doesn't clarify that CGO_ENABLED=1 is default make.bash
make.bat
make.rc
|
Change https://golang.org/cl/69430 mentions this issue: |
If there's a lack of interest in my e-mail to golang-dev dated 10 October 2017, @broady, not a fix per se, but time permitting, I suppose the changes, perhaps reworded according to developers' preferences, to the comments in make.bash, make.bat, and make.rc, could make their way into 1.9.2. I'm aware that the now edited #21662 (comment) diverges from the original subject of this tread as pertaining to html documentation. |
I doubt so. From the release policy:
Your proposal is definitely go1.10 material. Also, I don't understand why are you proposing to change comments in the build scripts. (almost) nobody reads those script. Doc changes should go in documentation pages. You'll need to explain what kind of problem we are trying to solve, and in which doc page the change will go, and what to change. |
https://github.com/bsbf2018/contrib Maint sub-branch perl-5.26.1 contains changes in commenting in the win32 Makefile and makefile.mk files, slightly modified from patches made to perl blead, the commenting changes to perl blead having largely been superseded. I don't see it as problematic to modify the commenting in make.bash, make.bat and make.rc prior to the next Go minor release, as 1.9.2, but again time permitting, and acknowledging that critical fixes are taking precedence in minor releases. |
pursuant to Go 1.9.2 @alexbrainman and @rsc, any interest in chipping in on #21662 (comment) and #21662 (comment) |
cf: https://golang.org/cl/69430 Does one expect the reader of golang.org/doc/install/source#ccompiler who thereafter might run a grep for "CGO_ENABLED" on make.bash, make.bat and make.rc, to know to look in src/go/build/zcgo.go? If the comments would be modified in make.bash, make.bat, and make.rc, that should be consistent with src/go/build/zcgo.go; obviously from that file defaultCGO_ENABLED = "" would be false for make.rc. Accordingly, #21662 (comment) was edited today. If golang.org/doc/install/source#ccompiler were modified, then the reader should be referred to src/go/build/zcgo.go, e.g., something along the lines of the below. "The file src/go/build/zcgo.go contains a list of platforms where CGO_ENABLED=1 is the default." |
@forskning I'm sorry, I don't really understand what you are getting at.
No. I don't expect anyone other than a core Go developer to ever look at src/go/build/zcgo.go. While the docs in make.bash, make.bat, and make.rc should be accurate, I don't expect anybody to read them. |
make.bash/make.bat/make.rc A.D.
I.L.T.
E.L.
different modi operandi I suppose I like concise and navigable documentation, easily accessible via pagers and Unix utilities. |
https://golang.org/doc/install/source On the above page is listed go1.4-bootstrap-20170531.tar.gz hyperlinked to https://storage.googleapis.com/golang/go1.4-bootstrap-20170531.tar.gz expanding Archived versions and then go1 one also finds listed go1.4-bootstrap-20170531.tar.gz accompanying a SHA256 Checksum, but hyperlinked to https://redirector.gvt1.com/edgedl/go/go1.4-bootstrap-20170531.tar.gz so, should the above expandable go1 be renamed to bootstrap and relocated under Stable versions? FWIW, regarding #21662 (comment), I wonder if someone might clarify the purpose of the presence of the CGO_ENABLED comment block in make.rc, my understanding is that noting Plan 9's C implementatation being a "dialect of ANSI C", that cgo is factually not supported on that OS. |
I think it's overkill to add a checksum there. |
How about adding a Checksum in parentheses next to go1.4-bootstrap-20170531.tar.gz?
https://golang.org/doc/install/source
The text was updated successfully, but these errors were encountered: