New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compress/gzip: issue6550 test fails #21661
Comments
I don't know what the .SlackBuild script does. There should be more information printed somewhere, showing what exactly failed. Can you find that? Note that compress/gzip/testdata/issue6550.gz is a binary file, so please verify that it was not corrupted anywhere during the build process. |
issue6550.gz is an intentionally corrupted file used in the unit tests... why does SlackBuild care about inspecting whether it is valid or not? |
The google-go-lang.SlackBuild script runs /sbin/makepkg at the end. The output as "WARNING: gzip test failed on usr/lib/go1.9/go/src/compress/gzip/testdata/issue6550.gz" https://mirrors.slackware.com/slackware/slackware-14.0/source/a/pkgtools/scripts/ Index of /slackware/slackware-14.0/source/a/pkgtools/scripts makepkg
|
My question is why SlackBuild cares about this at all? I don't see why some other packaging system should care about the files (especially test files) within a package. I really don't want our tests to be at the whim of whatever obscure rule package managers have. #14937 was already a case where we had to scrub all MTIME fields from gzip files for Debian. |
It was /sbin/makepkg (not the build script) that output this warning which informed what the package will contain, if the package factually is created, which it was, so I recommend closing the issue. The script /sbin/makepkg (not the Go code) was the source of the warning. |
Since this is just a warning, and I believe the correct place to fix this in makepkg, and not the Go project. Am I to correct to believe that there is nothing that we can do here? |
As dsnet inferred "issue6550.gz is an intentionally corrupted file used in the unit tests...".
Therefore, presuming the accuracy of that quoted statement, there's nothing to fix on the makepkg end; makepkg is doing its job WARNING of zero length files and also of the corrupt gzip file.
Seems that's the case. |
System: Slackware Linux (version 14.0)
CPUs: Intel(R) Atom(TM) CPU N270 @1.60GHz
Deps: go1.4-bootstrap-20170531.tar.gz,
go1.9.src.tar.gz
I created a package for installation on Slackware-14.0 (32bit) here.
I've never seen this output before near the end of running a .SlackBuild script.
This also occurs with version 1.8.3.
WARNING: gzip test failed on usr/lib/go1.9/go/src/compress/gzip/testdata/issue6550.gz
http://nurmi-labs.blogspot.com/2017/08/bootstrapping-go.html
The text was updated successfully, but these errors were encountered: