cmd/compile: "offset too large" error #21655

mei-rune · 2017-08-28T02:26:27Z

What version of Go are you using (`go version`)?

go version go1.9 windows/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (`go env`)?

go env
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=d:\dev\go\meijing;d:\dev\tpt_vendor;d:\dev\Godeps_workspace
set GORACE=
set GOROOT=d:\tools\go_amd64
set GOTOOLDIR=d:\tools\go_amd64\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\xxxx\AppData\Local\Temp\go-build851261075=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?

I compile my app, it is ok on go1.8 or go1.7
code is:

What did you expect to see?

it is compile ok.

What did you see instead?

cn/com/hengwei/poller

.\alert_action.go:448:2: offset too large in 02217 (d:\dev\meijing\src\cn\com\hengwei\poller\alert_action.go:428) MOVQ -17179868768(BX)(AX8),BX
.\alert_action.go:448:2: offset too large in 03783 (d:\dev\meijing\src\cn\com\hengwei\poller\alert_action.go:430) MOVQ -17179868768(DX)(CX8),DX
FAIL cn/com/hengwei/poller [build failed]

The text was updated successfully, but these errors were encountered:

dsnet · 2017-08-28T02:31:40Z

Hi. We're going to need something more than a screenshot to help debug this. At least paste a minimal reproduction of the problem.

\cc @randall77 @josharian

mei-rune · 2017-08-28T02:41:19Z

@dsnet this code is private, if you can promise not to spread it, nor use it elsewhere, and delete it after finding out the problem, I can send this code to your mail.

dsnet · 2017-08-28T04:17:54Z

Please don't send me anything. I have reported on compiler bugs before. You should be able to use process of elimination to eventually trim the problem down to a snippet that is safe to share. For example, #20333.

mei-rune · 2017-08-28T14:42:59Z

package abc

import (
	"math"
)

const current_status_internal_start = math.MaxInt32 - 50

func gen_message(ss []*string, current int) string {
	s := ss[current-current_status_internal_start]
	if nil != s {
		return ""
	}

	switch current {
	case 0:
		return "a"
	default:
		return "b"
	}
}

main.zip

D:\developing\go\meijing\src\abc>go build
# abc
.\main.go:15:2: offset too large in 00039 (d:\developing\go\meijing\src\abc\main.go:10) MOVQ    -17179868776(CX)(AX*8), CX

it is ok on the linux.

ghost · 2017-08-28T14:58:09Z

it is ok on the linux.

It's not, on my machine.

$ go build 
# github.com/opennota/a
./main.go:15:2: offset too large in 00039 (/home/opennota/gocode/src/github.com/opennota/a/main.go:10)       MOVQ    -17179868776(CX)(AX*8), CX

$ go version
go version go1.9 linux/amd64

$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/opennota/gocode"
GORACE=""
GOROOT="/home/opennota/go"
GOTOOLDIR="/home/opennota/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build906297495=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

mei-rune · 2017-08-28T15:06:09Z

@opennota yes, I made a mistake, it is fail also on the linux.

dsnet · 2017-08-28T19:49:01Z

@runner-mei, thank you for producing a minimal repro.

gopherbot · 2017-08-28T20:44:26Z

Change https://golang.org/cl/59630 mentions this issue: cmd/compile: avoid generating large offsets

randall77 · 2017-08-28T22:05:16Z

Reopening for cherry pick for 1.9.1.

rsc · 2017-10-13T18:56:00Z

~~CL 59630 OK for Go 1.9.2.~~
~~CL 70981 OK for Go 1.9.2. (resolved merge conflicts in cherry-pick)~~

gopherbot · 2017-10-15T01:52:52Z

Change https://golang.org/cl/70981 mentions this issue: [release-branch.go1.9] cmd/compile: avoid generating large offsets

The assembler barfs on large offsets. Make sure that all the instructions that need to have their offsets in an int32 1) check on any rule that computes offsets for such instructions 2) change their aux fields so the check builder checks it. The assembler also silently misassembled offsets between 1<<31 and 1<<32. Add a check in the assembler to barf on those as well. Fixes #21655 Change-Id: Iebf24bf10f9f37b3ea819ceb7d588251c0f46d7d Reviewed-on: https://go-review.googlesource.com/59630 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-on: https://go-review.googlesource.com/70981 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Keith Randall <khr@golang.org>

rsc · 2017-10-26T21:09:10Z

go1.9.2 has been packaged and includes:

CL 70981

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:09:10 UTC

mei-rune · 2017-12-07T02:41:29Z

This bug is still exists in the go 1.9.2 on windows/386

C:\tpt_programs\src> go version
go1.9.2 windows/386

C:\tpt_programs\src>go build
# _/C_/tpt_programs/src
.\main.go:15:2: offset too large in 00040 (C:\tpt_programs\src\main.go:10)      MOVL    -8589934388(CX)(AX*4), CX

ianlancetaylor · 2017-12-07T04:35:16Z

Still happens on tip too, with GOARCH=386. Reopening.

gopherbot · 2017-12-07T22:18:35Z

Change https://golang.org/cl/82675 mentions this issue: cmd/compile: fix large load/store offsets on 386

randall77 · 2017-12-08T03:58:26Z

Reopening for go 1.9.3.

andybons · 2018-01-18T19:27:17Z

CL 82675 OK for Go 1.9.3.

gopherbot · 2018-01-18T20:37:55Z

Change https://golang.org/cl/88324 mentions this issue: [release-branch.go1.9] cmd/compile: fix large load/store offsets on 386

Pointer arithemetic is done mod 2^32 on 386, so we can just drop the high bits of any large constant offsets. The bounds check will make sure wraparounds are never observed. Fixes #21655 Change-Id: I68ae5bbea9f02c73968ea2b21ca017e5ecb89223 Reviewed-on: https://go-review.googlesource.com/82675 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-on: https://go-review.googlesource.com/88324 Run-TryBot: Andrew Bonventre <andybons@golang.org> Reviewed-by: Keith Randall <khr@golang.org>

andybons · 2018-01-22T21:02:53Z

go1.9.3 has been packaged and includes:

CL 82675 cmd/compile: fix large load/store offsets on 386

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Jan 22 21:02:53 UTC

dsnet added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 28, 2017

dsnet changed the title ~~compile error on go1.9~~ cmd/compile: "offset too large" error Aug 28, 2017

dsnet added this to the Go1.9.1 milestone Aug 28, 2017

randall77 self-assigned this Aug 28, 2017

randall77 added NeedsFix The path to resolution is known, but the work has not been done. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Aug 28, 2017

gopherbot closed this as completed in 053840d Aug 28, 2017

randall77 reopened this Aug 28, 2017

rsc modified the milestones: Go1.9.1, Go1.9.2 Oct 4, 2017

ianlancetaylor added release-blocker and removed NeedsFix The path to resolution is known, but the work has not been done. labels Oct 13, 2017

rsc added the CherryPickApproved Used during the release process for point releases label Oct 14, 2017

rsc mentioned this issue Oct 15, 2017

all: Go 1.9.2 release status #22277

Closed

rsc closed this as completed Oct 26, 2017

ianlancetaylor reopened this Dec 7, 2017

ianlancetaylor modified the milestones: Go1.9.2, Go1.9.3 Dec 7, 2017

gopherbot closed this as completed in 4c800f0 Dec 8, 2017

randall77 reopened this Dec 8, 2017

randall77 removed CherryPickApproved Used during the release process for point releases release-blocker labels Dec 8, 2017

andybons mentioned this issue Jan 18, 2018

all: Go 1.9.3 release status #23475

Closed

andybons added the CherryPickApproved Used during the release process for point releases label Jan 18, 2018

This was referenced Jan 18, 2018

all: Go 1.9.3 release status #23476

Closed

all: Go 1.9.3 release status #23477

Closed

andybons closed this as completed Jan 22, 2018

golang locked and limited conversation to collaborators Jan 22, 2019

gopherbot added the FrozenDueToAge label Jan 22, 2019

rsc unassigned randall77 Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/compile: "offset too large" error #21655

cmd/compile: "offset too large" error #21655

mei-rune commented Aug 28, 2017

dsnet commented Aug 28, 2017

mei-rune commented Aug 28, 2017

dsnet commented Aug 28, 2017

mei-rune commented Aug 28, 2017 •

edited

ghost commented Aug 28, 2017 •

edited by ghost

mei-rune commented Aug 28, 2017

dsnet commented Aug 28, 2017

gopherbot commented Aug 28, 2017

randall77 commented Aug 28, 2017

rsc commented Oct 13, 2017 •

edited by andybons

gopherbot commented Oct 15, 2017

rsc commented Oct 26, 2017

mei-rune commented Dec 7, 2017 •

edited

ianlancetaylor commented Dec 7, 2017

gopherbot commented Dec 7, 2017

randall77 commented Dec 8, 2017

andybons commented Jan 18, 2018

gopherbot commented Jan 18, 2018

andybons commented Jan 22, 2018

cmd/compile: "offset too large" error #21655

cmd/compile: "offset too large" error #21655

Comments

mei-rune commented Aug 28, 2017

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

cn/com/hengwei/poller

dsnet commented Aug 28, 2017

mei-rune commented Aug 28, 2017

dsnet commented Aug 28, 2017

mei-rune commented Aug 28, 2017 • edited

ghost commented Aug 28, 2017 • edited by ghost

mei-rune commented Aug 28, 2017

dsnet commented Aug 28, 2017

gopherbot commented Aug 28, 2017

randall77 commented Aug 28, 2017

rsc commented Oct 13, 2017 • edited by andybons

gopherbot commented Oct 15, 2017

rsc commented Oct 26, 2017

mei-rune commented Dec 7, 2017 • edited

ianlancetaylor commented Dec 7, 2017

gopherbot commented Dec 7, 2017

randall77 commented Dec 8, 2017

andybons commented Jan 18, 2018

gopherbot commented Jan 18, 2018

andybons commented Jan 22, 2018

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mei-rune commented Aug 28, 2017 •

edited

ghost commented Aug 28, 2017 •

edited by ghost

rsc commented Oct 13, 2017 •

edited by andybons

mei-rune commented Dec 7, 2017 •

edited