Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: we shouldn't use MOVOstore instruction on plan9/amd64 #21625

Closed
0intro opened this issue Aug 25, 2017 · 1 comment
Closed

cmd/compile: we shouldn't use MOVOstore instruction on plan9/amd64 #21625

0intro opened this issue Aug 25, 2017 · 1 comment
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.10

Comments

@0intro
Copy link
Member

0intro commented Aug 25, 2017 •
edited

The SSA compiler currently generates MOVOstore instructions to optimize 16 bytes moves on AMD64 architecture.

These instructions were added in CL 16174.

See AMD64.rules:322 and AMD64.rules:351

However, we can't use the MOVOstore instruction on Plan 9, because floating point operations are not allowed in the note handler.

We should disable use of MOVOstore instruction on Plan 9, using the useSSE flag (disabled on Plan 9).
@0intro 0intro added this to the Go1.10 milestone Aug 25, 2017
@0intro 0intro self-assigned this Aug 25, 2017
@gopherbot
Copy link

Change https://golang.org/cl/59171 mentions this issue: cmd/compile: don't use MOVOstore for move on plan9/amd64

@golang golang locked and limited conversation to collaborators Aug 28, 2018
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@0intro @gopherbot