encoding/xml: improve package based on the suggestions from metalinter #21578
Labels
Comments
ianlancetaylor
changed the title
|
Please do not send in changes merely to reduce the cyclomatic complexity, unless those changes clearly make the code more readable. Note that some of the warnings in the doc seem simply incorrect. Thanks. |
|
Sure, will do. I was thinking about splitting of marshalStruct function to the separate functions based on the flags value, what do you think about? |
|
Change https://golang.org/cl/58210 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?go1.8.3 linux/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env)?GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/admin/go-workspace"
GORACE=""
GOROOT="/opt/go"
GOTOOLDIR="/opt/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build725687701=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
What did you do?
I run metalinter tool in the encoding/xml package and I saw bunch of errors and warnings:
metalinter-output.txt
So I started to fix them.
The text was updated successfully, but these errors were encountered: