Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go get -u' has problems updating vendored git submodules from commit 3ce05d2 onward #21497

Closed
siebenmann opened this issue Aug 17, 2017 · 1 comment
Closed

cmd/go: 'go get -u' has problems updating vendored git submodules from commit 3ce05d2 onward #21497

siebenmann opened this issue Aug 17, 2017 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.10

Comments

@siebenmann
Copy link

What version of Go are you using (go version)?

This happens with the latest git tip go version devel +b5dab2b, and this specific form of the issue started happening from devel +3ce05d2 onward.

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"

What did you do?

Starting from commit 3ce05d2 'cmd/go: add support for Fossil SCM to go get', go get -u appears to attempt to update vendored git submodules but is apparently trying to do it in a way that doesn't work. This may have been not working properly for some time but previously masked by the issue from #13657, which probably prevented go get -u from trying this git update of such submodules.

Here is a reproduction and output from it:

$ export GOPATH=/tmp/scr; mkdir $GOPATH
$ go get github.com/davecheney/httpstat

$ go get -u github.com/davecheney/httpstat
# cd /tmp/scr/src/github.com/davecheney/httpstat/vendor/github.com/fatih/color; git pull --ff-only
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

package github.com/davecheney/httpstat/vendor/github.com/fatih/color: exit status 1
# cd /tmp/scr/src/github.com/davecheney/httpstat/vendor/golang.org/x/net; git pull --ff-only
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

package github.com/davecheney/httpstat/vendor/golang.org/x/net/http2: exit status 1
@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Aug 17, 2017
@ianlancetaylor ianlancetaylor added release-blocker NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 17, 2017
@rsc
Copy link
Contributor

rsc commented Dec 1, 2017

Seems to have been fixed:

r$ export GOPATH=/tmp/scr; mkdir $GOPATH
r$ go get github.com/davecheney/httpstat
r$ go get -u github.com/davecheney/httpstat
r$

@rsc rsc closed this as completed Dec 1, 2017
@golang golang locked and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@rsc @siebenmann @ianlancetaylor @gopherbot