Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: CL https://golang.org/cl/55130 breaks freebsd-386-110 & freebsd-arm build #21437

Closed
paulzhol opened this issue Aug 14, 2017 · 1 comment
Closed

syscall: CL https://golang.org/cl/55130 breaks freebsd-386-110 & freebsd-arm build #21437

paulzhol opened this issue Aug 14, 2017 · 1 comment
Labels
FrozenDueToAge

Comments

@paulzhol
Copy link
Member

paulzhol commented Aug 14, 2017 •
edited

https://build.golang.org/log/aa20212879e503898785688aab364db08a3900db

ok  	net/url	0.007s
--- FAIL: TestChtimes (0.00s)
	os_test.go:1146: Chtimes /tmp/_Go_TestChtimes723456847: chtimes /tmp/_Go_TestChtimes723456847: invalid argument
--- FAIL: TestChtimesDir (0.00s)
	os_test.go:1146: Chtimes /tmp/_Go_TestChtimes185140834: chtimes /tmp/_Go_TestChtimes185140834: invalid argument
--- FAIL: TestLongPath (0.01s)
    --- FAIL: TestLongPath/length=247 (0.00s)
    	os_test.go:1967: Chtimes failed: chtimes /tmp/_Go_TestLongPath290002206/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir345x/bar.txt: invalid argument
    --- FAIL: TestLongPath/length=248 (0.00s)
    	os_test.go:1967: Chtimes failed: chtimes /tmp/_Go_TestLongPath290002206/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456x/bar.txt: invalid argument
    --- FAIL: TestLongPath/length=249 (0.00s)
    	os_test.go:1967: Chtimes failed: chtimes /tmp/_Go_TestLongPath290002206/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir34567x/bar.txt: invalid argument
    --- FAIL: TestLongPath/length=400 (0.00s)
    	os_test.go:1967: Chtimes failed: chtimes /tmp/_Go_TestLongPath290002206/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir3456789/dir34x/bar.txt: invalid argument
FAIL
FAIL	os	0.334s

CL https://golang.org/cl/55130 is missing the last int flag argument to utimensat.

truss output of TestChtimes on ARM results in EINVAL:

stat("/tmp/_Go_TestChtimes018285598",{ mode=-rw------- ,inode=8159,size=13,blksize=4096 }) = 0 (0x0)
utimensat(AT_FDCWD,"/tmp/_Go_TestChtimes018285598",{ 1502705791.693700000, 1502705791.693700000 },0x2) ERR#22 'Invalid argument'

not sure where that 0x02 is coming from, probably an uninitialized stack value. It triggers this check:
https://github.com/freebsd/freebsd/blob/releng/11.0/sys/kern/vfs_syscalls.c#L3215-L3216

I'm doing some tests and will send a CL soon.
@gopherbot
Copy link

Change https://golang.org/cl/55430 mentions this issue: syscall: add missing int flag argument to utimensat on *bsd and solaris

@wojas wojas mentioned this issue Nov 5, 2017
Closed
@golang golang locked and limited conversation to collaborators Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulzhol @gopherbot