Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: docs for SignCert omit mention of nonce #21384

Closed
cryslith opened this issue Aug 10, 2017 · 6 comments
Closed

x/crypto/ssh: docs for SignCert omit mention of nonce #21384

cryslith opened this issue Aug 10, 2017 · 6 comments
Labels
Documentation FrozenDueToAge
Milestone
Unreleased

Comments

@cryslith
Copy link

The documentation for Certificate.SignCert should note that it automatically sets c.Nonce to a 32-byte random nonce before signing.
@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2017
@jakob223
Copy link
Contributor

Add the relevant lines to the doc: https://go-review.googlesource.com/57051

@meirf
Copy link
Contributor

meirf commented Jul 6, 2018 •
edited

@tklauser any interest in reviewing this small change? I think "random" is useful since it implies that it's using the rand io.Reader argument.

@tklauser
Copy link
Member

tklauser commented Jul 6, 2018

@meirf thanks. I'm not familiar with this code, but I've added @FiloSottile as a reviewer to have a look at the CL.

@cryslith
Copy link
Author

Hi, I'd like to fix this. Is there a way for me to "adopt" the change that @jakob223 started, or should I create a new changeset?

@tklauser
Copy link
Member

Hi, I'd like to fix this. Is there a way for me to "adopt" the change that @jakob223 started, or should I create a new changeset?

@cryslith feel free to send a new CL, I don't think there is a way to adopt a CL.

@gopherbot
Copy link

Change https://golang.org/cl/230212 mentions this issue: ssh: improve docs on Certificate.SignCert

@golang golang locked and limited conversation to collaborators Apr 27, 2021
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@FiloSottile
ssh: improve docs on Certificate.SignCert
b8d59d0 
Document the fact that SignCert sets the Nonce field.  This makes it
clear that callers need not set it themselves.

Original change by Jakob Weisblat <jakobw@mit.edu> in CL 57051.

Fixes golang/go#21384

Change-Id: I161e0909ba6c8d07be5f8e68dc6e0f0392bea63f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/230212
Reviewed-by: Filippo Valsorda <filippo@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
ssh: improve docs on Certificate.SignCert
9294548 
Document the fact that SignCert sets the Nonce field.  This makes it
clear that callers need not set it themselves.

Original change by Jakob Weisblat <jakobw@mit.edu> in CL 57051.

Fixes golang/go#21384

Change-Id: I161e0909ba6c8d07be5f8e68dc6e0f0392bea63f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/230212
Reviewed-by: Filippo Valsorda <filippo@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
ssh: improve docs on Certificate.SignCert
bb7dedf 
Document the fact that SignCert sets the Nonce field.  This makes it
clear that callers need not set it themselves.

Original change by Jakob Weisblat <jakobw@mit.edu> in CL 57051.

Fixes golang/go#21384

Change-Id: I161e0909ba6c8d07be5f8e68dc6e0f0392bea63f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/230212
Reviewed-by: Filippo Valsorda <filippo@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@FiloSottile
ssh: improve docs on Certificate.SignCert
7a53a7c 
Document the fact that SignCert sets the Nonce field.  This makes it
clear that callers need not set it themselves.

Original change by Jakob Weisblat <jakobw@mit.edu> in CL 57051.

Fixes golang/go#21384

Change-Id: I161e0909ba6c8d07be5f8e68dc6e0f0392bea63f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/230212
Reviewed-by: Filippo Valsorda <filippo@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@FiloSottile
ssh: improve docs on Certificate.SignCert
d205c8a 
Document the fact that SignCert sets the Nonce field.  This makes it
clear that callers need not set it themselves.

Original change by Jakob Weisblat <jakobw@mit.edu> in CL 57051.

Fixes golang/go#21384

Change-Id: I161e0909ba6c8d07be5f8e68dc6e0f0392bea63f
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/230212
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@tklauser @cryslith @meirf @jakob223 @gopherbot