Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: CreateCertificate docs incompletely list template fields used #21363

Closed
cryslith opened this issue Aug 9, 2017 · 3 comments
Closed

crypto/x509: CreateCertificate docs incompletely list template fields used #21363

cryslith opened this issue Aug 9, 2017 · 3 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@cryslith
Copy link

cryslith commented Aug 9, 2017 •
edited

Similarly to #18962, the following fields of template are used by x509.CreateCertificate but are not listed as being used by that function in the docs:

  • ExtraExtensions
  • OCSPServer
  • IssuingCertificateURL
  • EmailAddresses
  • IPAddresses
  • PolicyIdentifiers
  • CRLDistributionPoints

(They are all used in buildExtensions, called by CreateCertificate).
@cryslith cryslith changed the title crypto/x509: CreateCertificate{,Request} docs incompletely list template fields used crypto/x509: CreateCertificate docs incompletely list template fields used Aug 9, 2017
@ianlancetaylor
Copy link
Contributor

CC @FiloSottile

@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 30, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 30, 2018
@gopherbot
Copy link

Change https://golang.org/cl/113916 mentions this issue: crypto/x509: document fields used in CreateCertificate

@martin-sucha
Copy link
Contributor

added a fix here: https://go-review.googlesource.com/c/go/+/113916

@golang golang locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@cryslith @martin-sucha @ianlancetaylor @gopherbot