-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: do the buildongce -make_basepin work automatically in the coordinator in the background #21305
Comments
Actually, repurpose this bug. Let's just make it automatically happen in the background in the coordinator. |
Change https://golang.org/cl/112162 mentions this issue: |
…ldongce * adds new buildgo.Client type to hold primarily a buildenv.Environment and a google.Credentials * starts to unify, document, and otherwise clean up how we look up authentication info. * use the new buildgo.Client type in the "buildongce" (poorly named) cluster bootstrap tool. * moves the "basepin" creation code from buildongce into a new method on buildgo.Client, for later use in the coordinator for golang/go#21305 Change-Id: I976b60c992bf67589e7f85fc5a9133f8cbb32e70 Reviewed-on: https://go-review.googlesource.com/112162 Reviewed-by: Bryan C. Mills <bcmills@google.com>
Change https://golang.org/cl/179419 mentions this issue: |
Change https://golang.org/cl/179617 mentions this issue: |
I flubbed my git in CL 179419. This was supposed to be included. Also updates some logging after watching it spam during testing. Updates golang/go#21305 Change-Id: Icbf32a064d8725c46ffddd422938bd8ff208c829 Reviewed-on: https://go-review.googlesource.com/c/build/+/179617 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Whenever somebody creates a new GCE image, it's important for latency reasons to create a base disk from that VM image in the region we use to run buildlet VMs.
If such a disk exists, future disk creations are Copy-On-Write and get created nearly instantly.
If a disk doesn't (and there's no hidden cache disk in the region from a recent creation), then you wait a bit for the copy from storage.
So
buildongce -make-basepin
auto-creates our "basepin" disks if needed.I don't know why I shoved that functionality into the
buildongce
tool. Maybe it should be its own tool.But in any case, we should have references to it from each env/**/{README,Makefile} so people updating these images in the future know to run it, or have the Makefiles auto-run it.
/cc @jessfraz @andybons @adams-sarah @cybrcodr
The text was updated successfully, but these errors were encountered: