New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/ssh/terminal: terminal using syscall.TCGETS (wrong for ppc64le) #21293
Comments
At crypto's master I see:
It looks like util_linux.go uses a hard-coded value. I guess that's wrong on ppc64le?
Oh, yup. That's easy. CL on its way. /cc @tklauser |
Change https://golang.org/cl/53073 mentions this issue: |
Should be fixed by https://golang.org/cl/51690 (commit golang/crypto@558b687) already. |
@tklauser, hah. Whoops. And now I see Gerrit said for mine:
I guess I hadn't synced either when I sent my change. Whoops. |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?master
What operating system and processor architecture are you using (
go env
)?What did you do?
This surfaced via logrus with sirupsen/logrus#604
I hit this when revendoring logrus into
moby/moby
. I don't have a reproducer but it's a known issue that syscall.TCGETS and syscall.TCSETS are incorrect for ppc64le. I've been slowly trying to move projects over to use x/sys/.I have a hacky test fix here: moby/moby#34332. Specifically, the windows bits were tricky (for me) to test because I don't have easy access to Windows.
When I have more time I can upstream the go bits unless someone else can get to it first.
The text was updated successfully, but these errors were encountered: