Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/cipher: use SIMD to improve xor performance #21269

Closed
templexxx opened this issue Aug 2, 2017 · 2 comments
Closed

crypto/cipher: use SIMD to improve xor performance #21269

templexxx opened this issue Aug 2, 2017 · 2 comments
Labels
FrozenDueToAge Performance
Milestone
Unplanned

Comments

@templexxx
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go1.8

What operating system and processor architecture are you using (go env)?

arch=amd64
os=darwin

What did you expect to see?

SIMD ( SSE2 SSSE3 or AVX2) will help xor's performance a lot.

I think I can make it
@bradfitz bradfitz changed the title crypto/cipher/xor.go: use SIMD to improve xor performance crypto/cipher: use SIMD to improve xor performance Aug 2, 2017
@bradfitz bradfitz added this to the Unplanned milestone Aug 2, 2017
@FiloSottile
Copy link
Contributor

Hi @templexxx, thanks for offering to make this.

I'll be happy to review a CL. Performance changes usually come with a benchstat.

You might want to have a look at #20967, too.

@ALTree
Copy link
Member

ALTree commented May 13, 2019

Implemented in 5168fcf. Closing here.

@ALTree ALTree closed this as completed May 13, 2019
@golang golang locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @FiloSottile @ALTree @gopherbot @templexxx