Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/base32: performance regression #21262

Closed
TocarIP opened this issue Aug 1, 2017 · 1 comment
Closed

encoding/base32: performance regression #21262

TocarIP opened this issue Aug 1, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Milestone

Comments

@TocarIP
Copy link
Contributor

TocarIP commented Aug 1, 2017

What version of Go are you using (go version)?

go version devel +623e2c4 Mon Jul 31 16:52:36 2017 +0000 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/localdisk/itocar/gopath"
GORACE=""
GOROOT="/localdisk/itocar/golang"
GOTOOLDIR="/localdisk/itocar/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build149758885=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

Run encoding/base32 benchmark EncodeToString

What did you expect to see?

Same or better performance as 1.8

What did you see instead?

Worse performance:
DecodeString-6 194µs ± 1% 158µs ± 2% -18.74% (p=0.000 n=10+10)

This is caused by 5f4f751

@gopherbot
Copy link

Change https://golang.org/cl/52510 mentions this issue: encoding/base32: improve performance in common case

@ALTree ALTree added this to the Go1.10 milestone Aug 10, 2017
@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. Performance labels Aug 10, 2017
@golang golang locked and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Projects
None yet
Development

No branches or pull requests

3 participants