Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/gerrit: Add TimeStamp.MarshalJSON #21261

Closed
lann opened this issue Aug 1, 2017 · 2 comments
Closed

x/build/gerrit: Add TimeStamp.MarshalJSON #21261

lann opened this issue Aug 1, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@lann
Copy link

lann commented Aug 1, 2017

I have a patch to add build/gerrit.TimeStamp.MarshalJSON, mirroring TimeStamp.UnmarshalJSON. This is the only change I have found necessary to support building a mock gerrit server for testing. I am aware that the API is generally unstable and am vendoring appropriately, but it would be convenient to upstream this change.
@gopherbot gopherbot added this to the Unreleased milestone Aug 1, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 1, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Aug 1, 2017

Sure.

@gopherbot
Copy link

Change https://golang.org/cl/52471 mentions this issue: Add TimeStamp.MarshalJSON() method

@golang golang locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @lann @gopherbot