Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: possible mistake in comment #21239

Closed
by-zhang opened this issue Jul 31, 2017 · 6 comments
Closed

net/rpc: possible mistake in comment #21239

by-zhang opened this issue Jul 31, 2017 · 6 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.10

Comments

@by-zhang
Copy link

In line 303 of the file net/rpc/server.go, the comment is inconsistent with the code below.
@bradfitz
Copy link
Contributor

"line 303" of what version?

@bradfitz
Copy link
Contributor

There is no comment on line 303 of Go 1.8.x.

So I guess you mean master (currently 623e2c4).

Here's a useful link:

go/src/net/rpc/server.go

Line 303 in 623e2c4

// First arg need not be a pointer.

@bradfitz bradfitz changed the title maybe there is a tiny mistake net/rpc: possible mistake in comment Jul 31, 2017
@bradfitz bradfitz added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 31, 2017
@bradfitz bradfitz added this to the Go1.10 milestone Jul 31, 2017
@by-zhang
Copy link
Author

by-zhang commented Aug 1, 2017

sry, I'm now little experienced with github. And you did the right job.

@enrichman
Copy link
Contributor

enrichman commented Aug 8, 2017 •
edited

I'm not sure if I had to claim the issue, but since it was a really small fix I submitted it:
https://go-review.googlesource.com/c/53750 :)

@gopherbot
Copy link

Change https://golang.org/cl/53750 mentions this issue: net/rpc: fixed comment in server.go

@ianlancetaylor
Copy link
Contributor

As noted on the CL, I think the comment is actually correct. The comment is not inconsistent with the code, it is meant to be read with the later comment.

I'm going to close this since I don't think there is a problem here. Please reply if you disagree.

@golang golang locked and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
5 participants
@bradfitz @enrichman @ianlancetaylor @gopherbot @by-zhang