Skip to content

x/tools/cmd/godoc: /cl/XXXX redirecting to go-review.googlesource.com/r/XXXX #21235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andybons opened this issue Jul 31, 2017 · 7 comments
Closed

x/tools/cmd/godoc: /cl/XXXX redirecting to go-review.googlesource.com/r/XXXX #21235

andybons opened this issue Jul 31, 2017 · 7 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@andybons
Copy link
Member

andybons commented Jul 31, 2017 •
edited
Loading

It should be redirecting to go-review.googlesource.com/XXXX
@andybons andybons self-assigned this Jul 31, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jul 31, 2017
@andybons andybons changed the title x/tools/cmd/godoc: /cl/51891 redirecting to go-review.googlesource.com/r/51891 x/tools/cmd/godoc: /cl/XXXX redirecting to go-review.googlesource.com/r/XXXX Jul 31, 2017
@bradfitz
Copy link
Contributor

Gerrit changes its URLs every few months. Is there really a canonical one? I thought they all redirected anyway.

(Actually curious.)

@andybons
Copy link
Member Author

I never actually knew about /r/NNNN. All I knew of is /NNNN and /c/NNNN. I’ll ask.

@andybons
Copy link
Member Author

No urls should have stopped working. Filed a bug with the team. In the meantime I’ll change it to /NNNN so that things work again.

@andybons
Copy link
Member Author

This actually is a PolyGerrit bug: https://bugs.chromium.org/p/gerrit/issues/detail?id=6888

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/52150 mentions this issue: x/tools/godoc: fix redirect to Gerrit

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/52170 mentions this issue: [release-branch.go1.8] x/tools/godoc: fix redirect to Gerrit

gopherbot pushed a commit to golang/tools that referenced this issue Jul 31, 2017
@andybons @broady
[release-branch.go1.8] x/tools/godoc: fix redirect to Gerrit
77187f3 
Redirects to /r/NNNN broke due to crbug.com/gerrit/6888.
Alternative URLs are available in the meantime: /NNNN and /c/NNNN.
This change uses the /NNNN format.

Fixes golang/go#21235

Change-Id: Ie30e01bedd7a8277aedd4070b5f82a754521ed03
Reviewed-on: https://go-review.googlesource.com/52150
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-on: https://go-review.googlesource.com/52170
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@dlsniper dlsniper mentioned this issue Jul 31, 2017
Closed
@broady
Copy link
Contributor

broady commented Jul 31, 2017

Deployed

@golang golang locked and limited conversation to collaborators Jul 31, 2018
henderjon pushed a commit to oggodoc/godoc that referenced this issue Jun 13, 2024
@andybons
x/tools/godoc: fix redirect to Gerrit
db1640b 
Redirects to /r/NNNN broke due to crbug.com/gerrit/6888.
Alternative URLs are available in the meantime: /NNNN and /c/NNNN.
This change uses the /NNNN format.

Fixes golang/go#21235

Change-Id: Ie30e01bedd7a8277aedd4070b5f82a754521ed03
Reviewed-on: https://go-review.googlesource.com/52150
Reviewed-by: Kevin Burke <kev@inburke.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @broady @andybons @gopherbot