You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the objdump output below, we see "q.go:3", which is nonsensical because this is the import statement's line number.
This happens because these instructions are getting their position information from the p.t struct literal's field initializers, but we're currently failing to serialize position information for OSTRUCTKEY. As a result, the nod(OSTRUCTKEY, ...) calls in bimport.go instead inherit the import statement's position information from lineno.
There are a handful of other nod calls (e.g., the OCONV nodes for importing OLITERALs, and the OIND and OADDR for importing OPTRLITs). These should all use explicit position information instead.
In the objdump output below, we see "q.go:3", which is nonsensical because this is the import statement's line number.
This happens because these instructions are getting their position information from the p.t struct literal's field initializers, but we're currently failing to serialize position information for OSTRUCTKEY. As a result, the nod(OSTRUCTKEY, ...) calls in bimport.go instead inherit the import statement's position information from lineno.
There are a handful of other nod calls (e.g., the OCONV nodes for importing OLITERALs, and the OIND and OADDR for importing OPTRLITs). These should all use explicit position information instead.
Related #19683.
/cc @hyangah @heschik @dr2chase
The text was updated successfully, but these errors were encountered: