Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: trybots should always compile for all platforms on subrepos #21163

Closed
bradfitz opened this issue Jul 25, 2017 · 4 comments
Closed

x/build: trybots should always compile for all platforms on subrepos #21163

bradfitz opened this issue Jul 25, 2017 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/47290/ broke the build for freebsd-386 which was reported in #21136

@ncw said:

According to https://go-review.googlesource.com/c/47290/ the trybots ran OK so I'm a bit puzzled about this.

We don't run all platforms for trybots since trybots are somewhat expensive, so we choose where to spend our resources. (We run freebsd-amd64 and linux-386 but not freebsd-386, for instance)

But we should at least run misc-compile (or equivalent) on trybots to make sure things compile everywhere.

/cc @adams-sarah @cybrcodr @andybons
@gopherbot gopherbot added this to the Unreleased milestone Jul 25, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 25, 2017
@bradfitz bradfitz mentioned this issue Jul 25, 2017
Closed
@bradfitz
Copy link
Contributor Author

bradfitz commented Aug 9, 2017

I looked into enabling this but it's not incredibly straightforward.

We can't just flip a bit on misc-compile-* builders because misc-compile uses the buildall.bash build script.

Looks like we'd need to write some code in the coordinator for it.

In addition to just running the equivalent of GOOS=os GOARCH=arch go install golang.org/x/subrepo/..., we'd probably also want to enumerate all the packages with tests and, for each, run GOOS=os GOARCH=arch go test -c golang.org/x/subrepo/each/package. (@josharian, where's that bug about not being able to use go test -c with multiple packages? That'd be nice here if we had it. Oh well.)

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 17, 2019
@bradfitz
Copy link
Contributor Author

bradfitz commented May 1, 2020

This would've caught a mistake just now on https://go-review.googlesource.com/c/sys/+/231277

/cc @dmitshur @andybons @cagedmantis

@dmitshur
Copy link
Contributor

dmitshur commented May 1, 2020

we'd probably also want to enumerate all the packages with tests and, for each, run GOOS=os GOARCH=arch go test -c golang.org/x/subrepo/each/package.

This should be easier now, we're already calling go list ./...to get a list of all Go packages in a golang.org/x repo in at least one place in cmd/coordinator (see CL 194397).

@dmitshur
Copy link
Contributor

dmitshur commented Jun 6, 2023

@mknyszek implemented this; closing as a duplicate of #58163.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot