Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update 1.4 release for -nopie fix #21116

Closed
josharian opened this issue Jul 21, 2017 · 6 comments
Closed

build: update 1.4 release for -nopie fix #21116

josharian opened this issue Jul 21, 2017 · 6 comments

Comments

@josharian
Copy link
Contributor

#21042 fixed an issue in the 1.4 release branch. We should update the 1.4 source release tarball and docs.

@broady @bradfitz

@josharian josharian added this to the Go1.4.4 milestone Jul 21, 2017
@ALTree
Copy link
Member

ALTree commented Jul 21, 2017

Tangential, but I'd suggest changing the milestone name to go1.4-bootstrap and the milestone description, it's quite misleading

We will likely never make a Go 1.4.4 release. The only reason to do so would be to ease bootstrapping of newer Go releases

a) we regularly publish new go1.4-bootstrap releases to "ease bootstrapping" b) they're not called go1.4.4, they're called go1.4-bootstrap

@josharian
Copy link
Contributor Author

I'd suggest changing the milestone name to go1.4-bootstrap and the milestone description

Huh. Apparently I can edit milestones (!). Done. Anyone who cares about the text there should review. cc @kevinburke in case maintner cares. I left the capital "G" in the milestone name to match the others for now.

@ALTree
Copy link
Member

ALTree commented Jul 24, 2017

Huh. Apparently I can edit milestones

@josharian me too. I think it's normal (for users marked as Member).

I asked (instead of changing it myself) because I wasn't sure people would be fine with it. New description looks fine to me BTW.

@josharian
Copy link
Contributor Author

I asked (instead of changing it myself) because I wasn't sure people would be fine with it.

Guess I'll ask forgiveness instead of permission then. :) I wish GitHub had all this config in the repo itself, so this could be codereviewed.

@ALTree
Copy link
Member

ALTree commented Sep 22, 2018

@josharian can you explain what's left to do here? AFAIK the no-pie issue is fixed and the patch already is on the 1.4 branch, which we document (in the install from source page):

To build a bootstrap toolchain from source, use either the git branch release-branch.go1.4 or go1.4-bootstrap-20171003.tar.gz, which contains the Go 1.4 source code plus accumulated fixes to keep the tools running on newer operating systems.

Can this issue be closed?

@josharian
Copy link
Contributor Author

@ALTree yes, thanks.

@golang golang locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants