Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: should post "CL nnnn mentions this issue." on recently closed issues #21106

Closed
dmitshur opened this issue Jul 20, 2017 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@dmitshur
Copy link
Contributor

Some CLs may refer to recently closed issues (e.g., fixups or followups). It'd be better if @gopherbot would post the usual "CL nnnn mentions this issue." comment in those situations.

Currently, the bot skips all closed issues when considering posting that message. This was done to avoid posting in really old, frozen issues (e.g., #1, #2, etc.) when they're accidentally referenced.

However, a better proxy is to check whether the issue has the FrozenDueToAge label, which the bot automatically applies to old issues that are closed (see here).

I ran into this in #21077 (comment).

I've discussed this change with @bradfitz at https://go-review.googlesource.com/c/39352/#message-8e361c0e3df415836dd3c4501d77fdf7beacc296.

CL incoming; this issue report is for posterity.

@gopherbot gopherbot added this to the Unreleased milestone Jul 20, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 20, 2017
@gopherbot
Copy link

CL https://golang.org/cl/50470 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants