I think it is good idea. And will not be too complicated to implement.
@pquerna, please, ping us if you won't get decision soon. Thank you.

Alex

@alexbrainman decision on this feature? Thanks!

@alexbrainman decision on this feature?

Like I said before, this sounds good to me. But I don't do deciding here, @rsc makes desisions. What do you think, Russ?

If we want this implemented for go1.10, we need to do it quickly - freeze for go1/10 is about to start https://groups.google.com/d/topic/golang-dev/csSLMsd7SF4/discussion

If we decide to do it, the change would have to include some test that demonstrates / verifies new feature. @pquerna do you have any suggestion for the test? Do you want to implement whole thing. if it is approved? Thank you.

Alex

The actual changes are small:

master...pquerna:windows_add_token_to_sys_proc_attr

Making a test case that launches a process at a lower integrity level is hard to do without a few hundred lines of new code (needs new bindings to CreateWellKnownSid, DuplicateTokenEx, SetTokenInformation, along with a few new structs/enums). Most of these could go into x/sys/windows, but that another whole set of CRs for a test case. With that dance, your test would look something like this: https://gist.github.com/pquerna/04f1933e5f6ced7f66f1f181d1c21ebf

Seems reasonable to me.

But the freeze for new features was today. (I just got back today)

Do you want to send a Gerrit change? If you can do it within this week and it looks safe, it might still make it to Go 1.10. Otherwise it'll likely be a Go 1.11 thing.

Change https://golang.org/cl/75253 mentions this issue: syscall: Add Token to Windows SysProcAttr

Making a test case that launches a process at a lower integrity level is hard to do without a few hundred lines of new code (needs new bindings to CreateWellKnownSid, DuplicateTokenEx, SetTokenInformation, along with a few new structs/enums). Most of these could go into x/sys/windows, but that another whole set of CRs for a test case. With that dance, your test would look something like this: https://gist.github.com/pquerna/04f1933e5f6ced7f66f1f181d1c21ebf

Yes I had something like that in mind. And we need to test your new code, so I would like to see that test before we discard it as "too many lines". We cannot put all that code into x/sys/window, because it needs to be part of main repo, so internal/syscall/windows is the place. Maybe we can use some of our existing code from syscall/security_windows.go. If you want to to another CR (or CRs) for the test that is fine too. Thank you.

Alex