Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: extra space in panic message #21102

Closed
kanata2 opened this issue Jul 20, 2017 · 2 comments
Closed

net/http: extra space in panic message #21102

kanata2 opened this issue Jul 20, 2017 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@kanata2
Copy link
Contributor

kanata2 commented Jul 20, 2017

In net/http/server.go,

if pattern == "" {
    panic("http: invalid pattern " + pattern)
}

I think the last space of "http: invalid pattern " and + pattern are unnecessary because pattern is an empty string, so please review this 馃檹
I'll send a change request if there is no problem.

@bradfitz
Copy link
Contributor

Yeah, that looks like a copy/paste oversight from a few lines later.

Sure, send a change.

@bradfitz bradfitz added this to the Go1.10 milestone Jul 20, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 20, 2017
@gopherbot
Copy link

CL https://golang.org/cl/50350 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants