Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/godoc: {tip,beta}.golang.org should redirect to https #21073

Closed
dmitshur opened this issue Jul 18, 2017 · 4 comments
Closed

x/tools/cmd/godoc: {tip,beta}.golang.org should redirect to https #21073

dmitshur opened this issue Jul 18, 2017 · 4 comments
Labels
FrozenDueToAge Security
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

http://golang.org redirects to https://golang.org (as do blog, tour, etc., subdomains), but http://beta.golang.org and http://tip.golang.org do not redirect to their https equivalent.

Is this an oversight? Or is it intentional (e.g., because it's needed for testing, or because it's too hard to redirect those domains)?

Unless there's a good reason for it, they should redirect to https. It's inconvenient and uses up people's time having to manually modify URLs to https form when visiting or sharing/pasting URLs.
@bradfitz
Copy link
Contributor

No reason.

Because it was easiest, perhaps.

@bradfitz bradfitz changed the title http://{tip,beta}.golang.org should redirect to https. x/tools/cmd/godoc: {tip,beta}.golang.org should redirect to https Jul 18, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2017
@kevinburke
Copy link
Contributor

previously: #19759

@agnivade
Copy link
Contributor

Just wanted to mention that tip.golang.org redirects to https now. I can send a CL to make the change for beta.golang.org also, if somebody can point out where to make that change.

For tip, there is a special x/tools/cmd/tip, I don't see anything like that for beta.golang.org. There is just this comment inside cmd/godoc/autocert.go though.

// TODO: make this the default? We're in the Go 1.8 freeze now, so
// this is too invasive to be default, but we want it for
// https://beta.golang.org/

@gopherbot
Copy link

Change https://golang.org/cl/120056 mentions this issue: cmd/tip: make tip.golang.org also serve & redirect beta.golang.org to tip

@golang golang locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Security
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @kevinburke @agnivade @dmitshur @gopherbot